-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add knowledge horizon functions to sensor specifications #25
Comments
@Flix6x I would need some more explanation to understand this issue. |
tldr: consider skipping over this issue. The price sensor is currently set up with the default knowledge horizon function for sensors recording physical events. See https://github.com/SeitaBV/timely-beliefs/blob/main/timely_beliefs/docs/timing.md for background info on the concept of knowledge horizons. The correct knowledge horizon function is given by me above. An example of how to pass this to This issue is a bit tricky, though, because we'd like to make sure that the sensor ID remains unchanged (API users depend on this), rather than a new price sensor being set up whenever this plugin's price import CLI command is run. That involves a database migration that updates the ENTSO-E price sensor entry in the sensor table, AND also recomputes the belief horizons of all previous timed beliefs entries in the timed_belief table for the ENTSO-E price sensor, in a non-trivial manner.[1] [1] Specifically, by first calculating the belief time from the belief horizon, using the old knowledge horizon function, and then calculating the belief horizon from the belief time, using the new knowledge horizon function. For example, the entry:
Complications in this calculation involve timezones and DST transitions, not to mention the fact that we haven't thought through the implications of having a need for a database migration coming from a plugin. I wouldn't recommend picking up this issue right now. |
Specifically, the ENTSO-E price sensor should be set up with
For the other sensors, the default suffices.
The text was updated successfully, but these errors were encountered: