Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer loader: reset classmap? #3

Open
donquixote opened this issue Jul 19, 2013 · 1 comment
Open

Composer loader: reset classmap? #3

donquixote opened this issue Jul 19, 2013 · 1 comment

Comments

@donquixote
Copy link
Contributor

The composer loader (at least the version that is being benchmarked) remembers if a class does not exist, and skips the lengthy operations next time.

This is nice, but I wonder if it is intended for the benchmark?
Composer gets very attractive numbers in the last benchmark (fail 500 classes), and mostly this is because of the repetition.
Intended or not?

@Seldaek
Copy link
Owner

Seldaek commented Jul 25, 2013

I think it should be taken into account because it can happen that hot code does check for a class's presence, and it would suck if the autoloader can't handle it gracefully. That said it might be better to have two tests, one with 500 random (unique) class names, and one with 500 times the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants