Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimized view #148

Open
alexIslander opened this issue Nov 30, 2020 · 10 comments
Open

Minimized view #148

alexIslander opened this issue Nov 30, 2020 · 10 comments
Labels
enhancement New feature or request

Comments

@alexIslander
Copy link

Hi ShankyTiwari,
I'm trying to integrate the menu into my project, which was straight forward according to the documentation. I'd like to go a step further regarding the usage. My project uses Angular Material and the menu is embedded in a drawer/sidebar.

I discovered a possible improvement in the library. It would be the 'minimise' feature. It would do the following:

  • with the help of an animation the view of a menu item could be minimised to an icon view. The animation would hide the label and the expand icon( if applies)
  • the 'minimise' could be triggered with an arrow icon (<- ->)
  • The 'minimise' icon could be placed according to configuration (top, bottom)

minimise

This concept is similar like this:
https://stackblitz.com/edit/angular-8zy3pi?file=src%2Fapp%2Fcomponents%2Fleft-menu%2Fleft-menu.component.ts

Kindly share your idea about this feature.

Regards,
AlexIslander

@ShankyTiwari
Copy link
Owner

Hi @alexIslander

It's a really nice feature to have. iI you are ready with the code, can you please create a new PR?
Also, please work on the latest fork since I have added a lot of examples for the demo. It would be helpful in testing & especially working with custom templates feature.

Looking forward to the PR.

Thanks,

@ShankyTiwari ShankyTiwari added the enhancement New feature or request label Dec 1, 2020
@alexIslander
Copy link
Author

I will sen the PR, when i'm ready with the feature.

@ShankyTiwari
Copy link
Owner

Yup, Works @alexIslander.

@alexIslander
Copy link
Author

Yup, Works @alexIslander.

@ShankyTiwari I have PR, kindly have a look on it.

@ShankyTiwari
Copy link
Owner

Hi @alexIslander Sure, I'll check in. Weekends. Thanks

@alexIslander
Copy link
Author

@ShankyTiwari kindly check my PR to '155-merge' branch. Thx

@packe100
Copy link

Hi, what is the development status of this feature?
Thank you

@alexIslander
Copy link
Author

Hi, what is the development status of this feature?
Thank you

Hi, waiting for review and merge: #171

@packe100
Copy link

@alexIslander thank you for your reply.
If I wanted to try out your work and integrate into my project, wich is the procedure? (sorry for this newbie question..).
I did checkout your branch... now I think I have to compile and produce a package?

Thank you

@alexIslander
Copy link
Author

The ideal way is when the feature merged and released by the owner of the library @ShankyTiwari .
In case it's not happening you can go down this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants