Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions on implementation of dropping #39

Open
shuuchen opened this issue Apr 30, 2021 · 0 comments
Open

Questions on implementation of dropping #39

shuuchen opened this issue Apr 30, 2021 · 0 comments

Comments

@shuuchen
Copy link

Hi,

I have some questions on the consistency of implementation of dropping and paper.

  1. When you take the sum, you did not use absolute values as written in the paper.

    di = wi.sum(0).sort()[1][self.count:self.count + delta]

  2. You drop during the stage, not when the stage finishes, as written in the paper.

    if not self._reach_stage(stage):

Am I wrong or would you explain about it ? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant