Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quick Add Bulk] - Clean up network requests #3400

Closed
sofiamatulis opened this issue Apr 5, 2024 · 1 comment · Fixed by #3480
Closed

[Quick Add Bulk] - Clean up network requests #3400

sofiamatulis opened this issue Apr 5, 2024 · 1 comment · Fixed by #3480
Assignees

Comments

@sofiamatulis
Copy link
Contributor

sofiamatulis commented Apr 5, 2024

Describe the enhancement you'd like

Quick Add Bulk - Clean up network requests to improve performance:

https://screenshot.click/05-16-6bol4-qljje.mp4

Let's cache the modals

@nicklepine nicklepine changed the title Quick Add Bulk - Clean up network requests [Quick Add Bulk] - Clean up network requests Apr 30, 2024
@sofiamatulis
Copy link
Contributor Author

sofiamatulis commented May 2, 2024

  1. intersection observer to load the modal html
  2. cache the data in JS (like filters https://github.com/Shopify/dawn/blob/main/assets/facets.js#L269)
  3. update cache when items are added to cart in the modal
  4. have pubsub listening to changes and updating cache as needed
  5. clear cache when navigating away from the page (will already happen since im saving it like filters in a var)
  6. note: promise may be needed in case of buyer opening the modal fast + adding items to cart in the modal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant