Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sigil cops ignore double commented sigils #156

Open
vinistock opened this issue Mar 13, 2023 · 0 comments
Open

Sigil cops ignore double commented sigils #156

vinistock opened this issue Mar 13, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@vinistock
Copy link
Member

It seems that our cops are not catching the usage of

# # typed: true

and end up adding another sigil above that one - even though Sorbet does seem to understand the double commented sigil. We should make our cops more robust to this and also remove the extra leading comments since only one is necessary.

@vinistock vinistock added the bug Something isn't working label Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant