Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paramType in schema improperly described #3

Open
jcfr opened this issue Mar 22, 2012 · 3 comments
Open

paramType in schema improperly described #3

jcfr opened this issue Mar 22, 2012 · 3 comments
Assignees

Comments

@jcfr
Copy link
Member

jcfr commented Mar 22, 2012

Looking at the schema allowing to validated the XML description, I noticed that the paramType is specified as a xsd:choice of name, flag, longflag, ... which is probably incorrect.

For example, I believe name is mandatory, at least flag or longflag should be specified, ...

See https://github.com/Slicer/SlicerExecutionModel/blob/master/ModuleDescriptionParser/ModuleDescription.xsd#L52

For reference, what motivated the creation of this issue if what's discussed here: http://www.na-mic.org/Bug/view.php?id=1828

@ghost ghost assigned finetjul Mar 22, 2012
@saschazelzer
Copy link

Some time ago we had a short mail discussion about a possible official xsd file for the xml (unfortunately, we did not reach any agreement/consensus yet). I posted a modified version of Julien's original schema file which would also solve the issue reported here:

https://gist.github.com/1584291

@millerjv
Copy link
Member

I am not well versed in XML schema, so I'd have to dig through the documentation to comment on whether xsd:choice is the right field.

I can comment that a parameter must have either

  1. a flag or a longflag or both, XOR
  2. a index in the index parameter list

In other words, a parameter is either a flag parameter (meaning the parameter is optional and does not need to be specified) or an index parameter (meaning the parameter must be specified).

"name" is a required field.

@saschazelzer
Copy link

That is exactly how I interpreted it from reading the parser code and wiki documentation. The posted xsd file models these requirements exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants