Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not approve STTT to Uniswap contract via Uniswap website #5

Open
zhangzhongnan928 opened this issue Mar 5, 2024 · 12 comments
Open
Assignees

Comments

@zhangzhongnan928
Copy link
Member

zhangzhongnan928 commented Mar 5, 2024

Screenshot 2024-03-05 at 4 17 20 pm

https://app.uniswap.org/swap?exactField=output&exactAmount=110&outputCurrency=eth&inputCurrency=0x63F7fF78ebB6591445FbaE524775C13715765098&chain=sepolia

after click approve button, Metamask is not triggered

@oleggrib
Copy link
Collaborator

oleggrib commented Mar 6, 2024

@oleggrib
Copy link
Collaborator

oleggrib commented Mar 6, 2024

Hi, @zhangzhongnan928 @SmartLayer , I can see the issue.
Uniswap requests approve(0x000000000022d473030f116ddee9f6b43ac78ba3, 0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff), and ST404 tries to parse 0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff as tokenId.
let me fix and deploy updated contract.

@oleggrib
Copy link
Collaborator

oleggrib commented Mar 6, 2024

@zhangzhongnan928
Copy link
Member Author

@zhangzhongnan928 , this is updated contract with fixed issue https://sepolia.etherscan.io/address/0xe565EE6a0F777b8DA85f5e1aF82aDF6af403c000#code

Screenshot 2024-03-07 at 11 02 10 am

This token cannot be added as 20 token in metamask

@oleggrib
Copy link
Collaborator

oleggrib commented Mar 7, 2024

yes, its same as my issue
#9
I have added supportsInterface(ERC721), but it conflicts with Metamask
this is fixed contract
https://sepolia.etherscan.io/address/0x2b0Aaa48b5669c7979a3BCa9cCB36D7f9669D28c#code
@zhangzhongnan928

@zhangzhongnan928
Copy link
Member Author

@oleggrib
Copy link
Collaborator

oleggrib commented Mar 7, 2024

Hi, @zhangzhongnan928 , could you show me error from brower console?

@oleggrib
Copy link
Collaborator

oleggrib commented Mar 8, 2024

most of all its problem with gas limit.
uniswap request Metamast to estimate gas and metamask reverts transaction.
1k tokens liquidity works good
to add more tokens we have to whitelist uniswap liquidity contract, because when it transfer ERC20 then lot of events emitted.

other issues with Approve fixed @zhangzhongnan928

@SmartLayer
Copy link
Contributor

SmartLayer commented Mar 8, 2024

Can Oleg check first? I'll get back to you.

@oleggrib
Copy link
Collaborator

oleggrib commented Mar 8, 2024

I am sorry, but I dont have access to the wallet 0x8349Fc69c48aF23e030A655736375d8942De5347, which is admin of our testnet contracts
uniswap creates separate contract for each pool, so contract to whitelist will be different for each uniswap pool

for example
https://sepolia.etherscan.io/tx/0x845e21e8bf08def3320f33106cee66999750eddcb1b504f5e4ab7eb3c358ff0d#eventlog
image

so we have to find out desired pool and whitelist it @SmartLayer

@SmartLayer
Copy link
Contributor

I think we need to redeploy it on Sepolia and attempt to create liquidity pool using uniswap api interface, the last deployment was a few days ago. we need to whitelist it and write down the process in case victor wants to see the result. I'll deploy a new version once you merged in the latest change.

@oleggrib
Copy link
Collaborator

Hi, @SmartLayer , all contract updates pushed, you can use script to deploy and set Admin, which is better for you
please, use command
await erc404st.connect(owner).setWhitelist(some.address, true)
to set whitelisted address, or verify contract and use Etherscan UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants