Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user tagging #634

Open
1 of 3 tasks
crablar opened this issue Feb 12, 2020 · 1 comment · Fixed by #637
Open
1 of 3 tasks

Fix user tagging #634

crablar opened this issue Feb 12, 2020 · 1 comment · Fixed by #637
Assignees

Comments

@crablar
Copy link
Member

crablar commented Feb 12, 2020

Current experience:

  • go here

  • go to the comment and type "@" to start looking for a user; we have a large number of user accounts who do not have a first name + last name who have the name "Software Engineer"

  • if you play around with the tagging interface, you will see that it does not appear in a consistent place throughout the page; also, the top search result gets highlighted even as you scroll down to other results

  • we should not have any of the "Software Engineer" people in these search results

  • the top result should not stay highlighted as you scroll down

  • comment interface should render in a consistent place on the page every time

Please use Slack's @ tagging feature as a reference.

@crablar crablar created this issue from a note in Frontend Improvements (To Do) Feb 12, 2020
@marcosschlup marcosschlup moved this from To Do to Doing in Frontend Improvements Feb 13, 2020
@marcosschlup marcosschlup linked a pull request Feb 14, 2020 that will close this issue
sterlingrules added a commit that referenced this issue Feb 14, 2020
@marcosschlup
Copy link
Collaborator

@crablar do you think we can close this issue or do we leave those items for later?

@marcosschlup marcosschlup moved this from Doing to Done in Frontend Improvements Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants