Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with ConfigInitializer not supporting the new OAuth #1145

Open
Frooodle opened this issue Apr 29, 2024 · 6 comments
Open

Issue with ConfigInitializer not supporting the new OAuth #1145

Frooodle opened this issue Apr 29, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@Frooodle
Copy link
Member

Frooodle commented Apr 29, 2024

ConfigInitializer script is done badly and doesnt support 3 layered configs like the OAuth section. And has issues with tags of same name (two enabled etc)

Script should be fixed to allow better merging of yml files etc

@Frooodle Frooodle added the bug Something isn't working label Apr 29, 2024
@Ludy87
Copy link
Contributor

Ludy87 commented May 2, 2024

The enable in oauth is actually not necessary, if oauth is activated, then the function is activated. Or have I thought incorrectly about that?

@Frooodle
Copy link
Member Author

Frooodle commented May 2, 2024

it could be done via a config presence check instead of a enable flag itself but due to how spring beans work it needs some conditional check

@Ludy87
Copy link
Contributor

Ludy87 commented May 2, 2024

There should be clarity by checking the issuer, clientId and clientSecret

@Frooodle
Copy link
Member Author

Frooodle commented May 3, 2024

Fixed by splitting settings.yml and custom_settings.yml
Settings.yml is stirling-pdf settings
custom_settings.yml is any user entered settings such as server.port etc

@Frooodle
Copy link
Member Author

Frooodle commented May 3, 2024

Im a idiiot keeping this open

@Ludy87
Copy link
Contributor

Ludy87 commented May 25, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants