Add VCS-based sidebar label coloring #217
Conversation
alecmev
force-pushed
the
vcs
branch
3 times, most recently
from
0be2610
to
ec8654f
Compare
|
Thanks for the contribution! Will test this locally and review the changes! |
|
@marcofugaro Took a closer look at the other themes, besides Eighties, and yeah, those needed tuning, especially Light. Also got rid of the selected effect, doesn't look good, and isn't really necessary. |
|
Rebased to fix a conflict in readme. |
|
@kkga @marcofugaro Hi! I'm willing to adopt this theme. Could fork, but I don't intend to change much, just modernize. |
|
@alecmev hey! Thanks for your interest. Do you want to move this repo to community packages org? |
|
@kkga Yeah! I haven't coordinated with them yet though. I think you need to be a part of an organization to be able to transfer to it. You can transfer to me, and I can take care of the rest, what do you prefer? |
|
Hello, I am your person of contact for moving packages to the SublimeText org. Your assessments have been correct so far. The person moving the repo needs to be a part of the org and since @alecmev volunteered to take maintainership, I invited him. I suggest the following procedure
From then on, you are free to do whatever you would if the package hadn't been moved, i.e. push new updates by creating a new tag. |
|
@alecmev any idea what this means?
|
|
Ah, I suspect that is because of an already existing fork. I didn't think of that. You may also transfer the repo to me and I will take care of transfering it to the org. |
Indeed! I renamed the fork to
I already submitted a "detach a fork" request to GitHub, but this is faster, thanks for offering! @kkga Can you transfer to @FichteFoll instead, please? |
|
@kkga The fork has been detached, just in case, so you can transfer to me too 😉 |
|
The transferto @FichteFoll is already in progress. Just waiting for them to accept I think. |
|
Indeed, all done on my part. |
|
Great, thanks all! |
|
Thank you! 👍 |
It has migrated: SublimeText/Spacegray#217 (comment)
It has migrated: SublimeText/Spacegray#217 (comment)
|
Is there any progress? @alecmev |
|
Didn't realize there was demand, will try to clean up and release soon. This isn't ready as-is yet, unfortunately, as I've noticed some inconsistencies between dark/light in personal use. |
Essentially a copy-paste from Toxin, thanks @p3lim! One divination is that I chose to decolor the VCS badges, instead of outright hiding them, since they help distinguish created/modified from staged. Another is the italic for ignored files, which I wouldn't mind dropping, but it's somewhat useful.
Didn't know what colors to choose, so just looked at VS Code's Base16 Themes.
This is opt-in,
vcs_colorsetting enables the whole thing,vcs_color_expandedalso applies the coloring to expanded folders. The latter one is the same setting name as in Toxin, for potential interop.Added
variablesintroduced in 3179, because why not. Opted not to indent the rules as to not ruin the diff for the main feature and to not pollute the blame trail.baseprefix because reasons.Also piggybacked in a fix for #188, since the original PR has died a slow and painful death.
Fixes #214
Fixes #188