Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Symfony 7 #275

Open
tacman opened this issue Nov 28, 2023 · 3 comments
Open

Support Symfony 7 #275

tacman opened this issue Nov 28, 2023 · 3 comments

Comments

@tacman
Copy link

tacman commented Nov 28, 2023

Symfony 7 will be out in a few days. It would be great if the bundle could be installed when using it.

@tacman
Copy link
Author

tacman commented Nov 28, 2023

I forked this bundle, but tests aren't passing even before I start testing with Symfony 7.

I think the problem is that the tests using annotations in the entity classes, not attributes. And some related things like that.

tac@tac-desktop1:~/g/tacman/reset-password-bundle$ vendor/bin/simple-phpunit 


There were 18 errors:

1) SymfonyCasts\Bundle\ResetPassword\Tests\FunctionalTests\Command\ResetPasswordRemoveExpiredCommandTest::testRemoveExpiredCommandWithNothingToRemove
InvalidArgumentException: Can only configure "xml", "yml", "php", "staticphp" or "attribute" through the DoctrineBundle. Use your own bundle to configure other metadata drivers. You can register them by adding a new driver to the "doctrine.orm.default_metadata_driver" service definition.

/home/tac/g/tacman/reset-password-bundle/vendor/symfony/doctrine-bridge/DependencyInjection/AbstractDoctrineExtension.php:227
/home/tac/g/tacman/reset-password-bundle/vendor/symfony/doctrine-bridge/DependencyInjection/AbstractDoctrineExtension.php:97
/home/tac/g/tacman/reset-password-bundle/vendor/doctrine/doctrine-bundle/DependencyInjection/DoctrineExtension.php:837
/home/tac/g/tacman/reset-password-bundle/vendor/doctrine/doctrine-bundle/DependencyInjection/DoctrineExtension.php:657
/home/tac/g/tacman/reset-password-bundle/vendor/doctrine/doctrine-bundle/DependencyInjection/DoctrineExtension.php:584
/home/tac/g/tacman/reset-password-bundle/vendor/doctrine/doctrine-bundle/DependencyInjection/DoctrineExtension.php:114
/home/tac/g/tacman/reset-password-bundle/vendor/symfony/dependency-injection/Compiler/MergeExtensionConfigurationPass.php:76
/home/tac/g/tacman/reset-password-bundle/vendor/symfony/http-kernel/DependencyInjection/MergeExtensionConfigurationPass.php:42
/home/tac/g/tacman/reset-password-bundle/vendor/symfony/dependency-injection/Compiler/Compiler.php:80
/home/tac/g/tacman/reset-password-bundle/vendor/symfony/dependency-injection/ContainerBuilder.php:767
/home/tac/g/tacman/reset-password-bundle/vendor/symfony/http-kernel/Kernel.php:506
/home/tac/g/tacman/reset-password-bundle/vendor/symfony/http-kernel/Kernel.php:763
/home/tac/g/tacman/reset-password-bundle/vendor/symfony/http-kernel/Kernel.php:126
/home/tac/g/tacman/reset-password-bundle/tests/FunctionalTests/Command/ResetPasswordRemoveExpiredCommandTest.php:43

@tacman
Copy link
Author

tacman commented Nov 28, 2023

attributes weren't supported until PHP 8, and this bundle only require php 7.2 (which is past EOL). I'm not sure how to proceed.

@bocharsky-bw
Copy link
Member

We have an open PR about it here: #274

Feel free to review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants