Skip to content
This repository has been archived by the owner on Jun 8, 2018. It is now read-only.

Error on Chrome #280

Open
underrobyn opened this issue May 20, 2018 · 4 comments
Open

Error on Chrome #280

underrobyn opened this issue May 20, 2018 · 4 comments

Comments

@underrobyn
Copy link

Just installed this to test it out, navigated to https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js and got the following error in the console:

Error in event handler for webRequest.onBeforeRequest/1: TypeError: Cannot set property 'details' of undefined
at chrome.webRequest.onBeforeRequest.addListener.types (chrome-extension://ldpochfccmkkmhdbclfhpagapcfdljkj/core/state-manager.js:214:57)

@Synzvato
Copy link
Owner

Hi @jake-cryptic, and many thanks for sharing your findings.

I'm unable to reproduce your issue, so I'll need some additional details. Could you please tell me what platform you were on, what exact version of Chrome you were using, and what other extensions you had installed? You could send these details via (encrypted) email, if you'd rather not make them public.

@underrobyn
Copy link
Author

Hi,
I think I've just figured it out, it only happens when you go to a new tab page.
I'm running Chrome 66.0.3359.181 on Windows 7 (x64), all other extensions are disabled

Screenshot of the error in the developer tools:
image

@Synzvato
Copy link
Owner

Synzvato commented Jun 3, 2018

Thanks for the additional details. Could you please navigate to chrome://settings/search#privacy and share the current state of your "Use a prediction service to load pages more quickly" checkbox?

@underrobyn
Copy link
Author

It was disabled, but no matter if it is enabled or disabled the same error occurs.

I personally think it's to do with the fact that the new tab page is chrome://newtab and I don't think extensions are allowed to modify those in some cases, maybe add a check to the function to see if requestDetails.url starts with http:// or https:// before trying to access it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants