Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I believe Crypt::CBC has removed the blocksize option from new #13

Open
rfdrake opened this issue Jan 9, 2023 · 1 comment
Open

I believe Crypt::CBC has removed the blocksize option from new #13

rfdrake opened this issue Jan 9, 2023 · 1 comment

Comments

@rfdrake
Copy link

rfdrake commented Jan 9, 2023

I saw this when running a unit test. I believe the change happened between Crypt::CBC 2.33 and Crypt::CBC 3.00 from 2021.
It's possible I'm doing something weird to trigger this that other people don't see. Or it's possible that not many people have upgraded Crypt::CBC recently.

I've created a bug report for Crypt::CBC with the same information. https://rt.cpan.org/Ticket/Display.html?id=145836

Error: 'blocksize' is not a recognized argument at /home/runner/work/tel/tel/local/lib/perl5/Crypt/CBC.pm line 312.
 at /home/runner/work/tel/tel/local/lib/perl5/Crypt/PWSafe3.pm line 260.
rfdrake added a commit to rfdrake/tel that referenced this issue Jan 9, 2023
@rfdrake
disable PWSafe3 because it's broken right now
02974ab 
https://rt.cpan.org/Ticket/Display.html?id=145836
TLINDEN/Crypt--PWSafe3#13
rfdrake added a commit to rfdrake/tel that referenced this issue Jan 10, 2023
@rfdrake
Squashed commit of the following:
a151db0 
commit 2a4a5f0
Author: Robert Drake <rfdrake@users.noreply.github.com>
Date:   Mon Jan 9 22:58:47 2023 -0500

    try again to remove redefine error

commit 8f15f76
Author: Robert Drake <rfdrake@users.noreply.github.com>
Date:   Mon Jan 9 22:50:59 2023 -0500

    notabs..

commit 15c6f13
Author: Robert Drake <rfdrake@users.noreply.github.com>
Date:   Mon Jan 9 22:46:05 2023 -0500

    update coveralls

commit 648bbb1
Author: Robert Drake <rfdrake@users.noreply.github.com>
Date:   Mon Jan 9 19:04:37 2023 -0500

    fix notabs

commit 02974ab
Author: Robert Drake <rfdrake@users.noreply.github.com>
Date:   Mon Jan 9 18:06:12 2023 -0500

    disable PWSafe3 because it's broken right now

    https://rt.cpan.org/Ticket/Display.html?id=145836
    TLINDEN/Crypt--PWSafe3#13

commit 2c573eb
Author: Robert Drake <rfdrake@users.noreply.github.com>
Date:   Mon Jan 9 17:17:52 2023 -0500

    more feature flags for test coverage

commit 94ea575
Author: Robert Drake <rfdrake@users.noreply.github.com>
Date:   Mon Jan 9 17:11:28 2023 -0500

    add Module::Install to requirements

commit b82ba94
Author: Robert Drake <rfdrake@users.noreply.github.com>
Date:   Mon Jan 9 17:07:29 2023 -0500

    really fix cpanfile

commit 99da6fb
Author: Robert Drake <rfdrake@users.noreply.github.com>
Date:   Mon Jan 9 17:04:12 2023 -0500

    try to fix the cpanfile again

commit 0123fee
Author: Robert Drake <rfdrake@users.noreply.github.com>
Date:   Mon Jan 9 16:58:40 2023 -0500

    fix cpanfile

commit 1951adb
Author: Robert Drake <rfdrake@users.noreply.github.com>
Date:   Mon Jan 9 16:56:21 2023 -0500

    fix for no runs-on in build

commit 4de6dc8
Author: Robert Drake <rfdrake@users.noreply.github.com>
Date:   Mon Jan 9 16:50:08 2023 -0500

    trying to fix coveralls again

    This also drops our support matrix and is only running CI on perl 5.34

commit 051a8d3
Author: Robert Drake <rfdrake@users.noreply.github.com>
Date:   Mon Jan 9 16:18:36 2023 -0500

    coveralls thing

commit 90d8fc7
Author: Robert Drake <rfdrake@users.noreply.github.com>
Date:   Mon Jan 9 14:01:54 2023 -0500

    spread the perl versions

commit 9469178
Author: Robert Drake <rfdrake@users.noreply.github.com>
Date:   Mon Jan 9 13:59:18 2023 -0500

    attempt to fix coveralls

commit 05b20f2
Author: Robert Drake <rfdrake@users.noreply.github.com>
Date:   Mon Jan 9 13:36:23 2023 -0500

    macos builds are expensive

commit c7a7e02
Author: Robert Drake <rfdrake@users.noreply.github.com>
Date:   Mon Jan 9 13:34:19 2023 -0500

    try to remove the redefine error

commit 587fa1d
Author: Robert Drake <rfdrake@users.noreply.github.com>
Date:   Mon Jan 9 13:33:34 2023 -0500

    doesn't work on windows

    IO and Expect don't build properly

commit 56a1147
Author: Robert Drake <rfdrake@users.noreply.github.com>
Date:   Mon Jan 9 13:24:57 2023 -0500

    override isatty in fake-a-router test

commit 5be0a5e
Author: Robert Drake <rfdrake@users.noreply.github.com>
Date:   Mon Jan 9 13:04:56 2023 -0500

    fix for . not being in @inc

commit e31cfc1
Author: Robert Drake <rfdrake@users.noreply.github.com>
Date:   Mon Jan 9 12:52:32 2023 -0500

    update cpanfile

commit f67be2d
Author: Robert Drake <rfdrake@users.noreply.github.com>
Date:   Mon Jan 9 12:51:41 2023 -0500

    add github-ci-testing to workflows
@TLINDEN
Copy link
Owner

TLINDEN commented Jan 12, 2023 •
edited

Hi,

current master removes the blocksize option, but there's another problem upstream, see: lstein/Lib-Crypt-CBC#5, therefore I did't release a new version yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TLINDEN @rfdrake