Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total size is calculated incorrectly for masonry grids #665

Open
2 tasks done
yekta opened this issue Feb 8, 2024 · 1 comment
Open
2 tasks done

Total size is calculated incorrectly for masonry grids #665

yekta opened this issue Feb 8, 2024 · 1 comment

Comments

@yekta
Copy link

yekta commented Feb 8, 2024

Describe the bug

I'm using @tanstack/svelte-virtual. With masonry type grids total size (.getTotalSize()) seems to be based on all other row heights + the height of the shortest item in the last row of the grid (instead tallest item in the latest row of the grid).

Expected behavior

For masonry type grids .getTotalSize() being calculated based on tallest item in each row instead of shortest item for the very last row.

Platform

macOS, Chrome

tanstack-virtual version

v3.0.4

Terms & Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
@davx1992
Copy link

Think it is fixed already in February. Installed latest version, and it is working correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants