Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put a test_number counter back into History #172

Closed
schwernbot opened this issue Mar 16, 2014 · 1 comment
Closed

Put a test_number counter back into History #172

schwernbot opened this issue Mar 16, 2014 · 1 comment

Comments

@schwernbot
Copy link

From: @schwern
Date: Wednesday Nov 09, 2011 at 20:50 GMT
Orig: Test-More/test-more#190

Now that the test_number is attached to the Result object there's less work for an EventWatcher to do and it's more generically applicable.

Move the counter out of the TAP formatter and into the History object.

History will track the last test_number seen on a result, so others can check if an incoming result is out of order. History's accept_result will set the last number seen to the result's test_number OR increment it if it doesn't have one.

History will also track if it's seen any out of order results and hold onto a list of them.

@schwernbot
Copy link
Author

From: @schwern
Date: Saturday Mar 31, 2012 at 16:27 GMT
Orig: Test-More/test-more#190 (comment)

I don't think the History should do any implicit shenanigans about setting the counter to match the result test number. I'd rather that was explicit behavior than try to guess.

History doesn't currently track out of order tests, but I think that's a separate issue.

So this can be closed up.

@schwern schwern closed this as completed Mar 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants