use_ok not works with versions

[schwern]

• GC-ID: 55
• GC-Labels: Type-Defect, Priority-Medium
• GC-Status: Accepted
• GC-Attachments: No

---

• From: happy.barney at Google Code
• Date: 2009-11-26T10:17:08

I have problem with version in use_ok:

use_ok (module, 1.0.0);
use_ok (module, v1.0.0);

after quick look in source codes (Test::More, version 0.94) following fix
comes to my mind (change line 816 with it):

$imports[0] = join '.', unpack 'U*', $imports[0]
if 'VSTRING' eq ref \ $imports[0];

if( @imports == 1 and $imports[0] =~ /^\d+(?:.\d+)*$/ ) {

---

• From: schwern at Google Code
• Date: 2010-05-19T23:09:33

Could you please show the output you got and what you expected? I think I know what
you're talking about, but I'd like to be sure.

---

• From: schwern at Google Code
• Date: 2010-05-19T23:21:19

---

• From: happy.barney at Google Code
• Date: 2010-05-20T05:10:36

for given examples i expect that use_ok use version check, same like perl do.

now, Test::More use import with arguments.

See also http://www.perlmonks.org/?node_id=809447

---

[rjbs]

A problem here is that perl can identify that something is a version by its literal form in the source code. That is:

use Some::Module 1.2;
use Some::Other "1.2";
use Some::Again (1.2);

In the first case, it is a version check for 1.2. In the second and third cases, an import request. use_ok can't determine this, because by the time it gets its @_, it's a variable that could be either.

I do not believe this can be made to do what you want.

[exodist]

closing. Not going to change use_ok at this point, use_ok is now discouraged and lots of upstream things break if we change it.