Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect against polluting $! or $@ with open() #268

Closed
schwern opened this issue Mar 30, 2012 · 0 comments
Closed

Protect against polluting $! or $@ with open() #268

schwern opened this issue Mar 30, 2012 · 0 comments
Assignees
@schwern
Labels
Bug Test-Builder2

Comments

@schwern
Copy link
Contributor

schwern commented Mar 30, 2012

Any call to open risks setting $!. This can innocently affect tests, such as autodie (see #266).

Rather than localize $! everywhere open is used, write a role to provide an open method which does this. See TB2::CanTry for a similar example.
@ghost ghost assigned schwern Mar 30, 2012
schwern added a commit that referenced this issue Mar 30, 2012
@schwern
Write a role to provide a safe open method, TB2::CanOpen
1d1ac7b 
For #268
schwern added a commit that referenced this issue Mar 30, 2012
@schwern
Make CanDupFileHandles no longer pollute $!
7b0cc2a 
Unfortunately its interface is too complicated to use TB2::CanOpen and its probably
not worth trying to make TB2::CanOpen support it.

For #268
schwern added a commit that referenced this issue Mar 30, 2012
@schwern
Protect $! in the few other places we use open()
14caa0d 
For #268
@schwern schwern closed this as completed Mar 30, 2012
@schwern schwern mentioned this issue Mar 30, 2012
Closed
@schwernbot schwernbot mentioned this issue Mar 16, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schwern schwern

Labels
Bug Test-Builder2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schwern