Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test-Simple-1.005000_005 does not pass tests #353

Closed
karenetheridge opened this issue Apr 11, 2013 · 8 comments
Closed

Test-Simple-1.005000_005 does not pass tests #353

karenetheridge opened this issue Apr 11, 2013 · 8 comments
Assignees

Comments

@karenetheridge
Copy link
Member

I just tried to install http://cpan.metacpan.org/authors/id/M/MS/MSCHWERN/Test-Simple-1.005000_005.tar.gz on perl 5.17.10 on darwin:

#   Failed test 'POD test for Test/More.pm'
#   at t/00compile.t line 41.
Wide character in print at /Users/ether/.cpanm/work/1365713186.47166/Test-Simple-1.005000_005/blib/lib/TB2/Streamer/Print.pm line 144.
# Test/More.pm (1760): Non-ASCII character seen before =encoding in '<98><83>'. Assuming UTF-8
#1 test of 20 failed.
t/00compile.t .............................. 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/20 subtests 

...

t/fail-like.t .............................. ok
#   Failed test at t/fail-more.t line 249.
#          got: '#   Failed test 'My Wibble isa Wibble'
# #   at t/fail-more.t line 248.
# #     My Wibble isn't a 'Wibble' it's a ''
# '
#     expected: '#   Failed test 'My Wibble isa Wibble'
# #   at t/fail-more.t line 248.
# #     My Wibble isn't a class or reference
# '
#   Failed test at t/fail-more.t line 249.
#          got: 'not ok - The class isa Wibble
# '
#     expected: 'not ok - The thing isa Wibble
# '
#   Failed test at t/fail-more.t line 249.
#          got: '#   Failed test 'The class isa Wibble'
# #   at t/fail-more.t line 248.
# #     The class isn't a 'Wibble' it's a ''
# '
#     expected: '#   Failed test 'The thing isa Wibble'
# #   at t/fail-more.t line 248.
# #     The thing isn't a class or reference
# '
t/fail-more.t .............................. 
Failed 3/80 subtests 
t/fail_one.t ............................... ok

...

t/pod-coverage.t ........................... skipped: set RELEASE_TESTING to test Pod coverage

#   Failed test 'POD test for blib/lib/Test/More.pm'
#   at /Users/ether/.perlbrew/libs/17.10@std/lib/perl5/Test/Pod.pm line 186.
Wide character in print at /Users/ether/.cpanm/work/1365713186.47166/Test-Simple-1.005000_005/blib/lib/TB2/Streamer/Print.pm line 144.
# blib/lib/Test/More.pm (1760): Non-ASCII character seen before =encoding in '
<98><83>'. Assuming UTF-8
#1 test of 67 failed.
t/pod.t .................................... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/67 subtests 

Test Summary Report
-------------------
t/00compile.t                            (Wstat: 256 Tests: 20 Failed: 1)
  Failed test:  18
  Non-zero exit status: 1
t/fail-more.t                            (Wstat: 0 Tests: 80 Failed: 3)
  Failed tests:  36-38
t/pod.t                                  (Wstat: 256 Tests: 67 Failed: 1)
  Failed test:  59
  Non-zero exit status: 1
Files=211, Tests=2127, 34 wallclock secs ( 1.03 usr  0.70 sys + 28.61 cusr  4.33 csys = 34.67 CPU)
Result: FAIL
Failed 3/211 test programs. 5/2127 subtests failed.
make: *** [test_dynamic] Error 255
-> FAIL Installing http://cpan.metacpan.org/authors/id/M/MS/MSCHWERN/Test-Simple-1.005000_005.tar.gz failed. See /Users/ether/.cpanm/build.log for details.
@schwern
Copy link
Contributor

schwern commented Apr 12, 2013

Thanks for the report.

I can reproduce the POD problems, I believe we've fixed these in
1582fb6. I can't reproduce the
problems with t/fail-like.

Would you have a look at the Test-Builder1.5 branch on Github and see
that has the same problems? Let us know and we'll fix them and cut a
new alpha.

@karenetheridge
Copy link
Member Author

all tests pass at the HEAD (64a4acd) of Test-Builder1.5!

@schwern
Copy link
Contributor

schwern commented Apr 12, 2013

Lovely! I'll cut an alpha.

@karenetheridge
Copy link
Member Author

Looks like I didn't test properly this morning, as the new release fails in t/fail-more.t, and now I can repro this under 5.17.10 on OSX in the git repo. So sorry about that! :(

t/CanLoad/taint.t .......................... Text::Soundex will be removed from 
the Perl core distribution in the next major release. Please install it from CPA
N. It is being used at /Users/ether/git/Test-More/blib/lib/TB2/CanLoad.pm, line 70.

t/fail-more.t .............................. 1/? #   Failed test at t/fail-more.t line 249.
#          got: '#   Failed test 'My Wibble isa Wibble'
# #   at t/fail-more.t line 248.
# #     My Wibble isn't a 'Wibble' it's a ''
# '
#     expected: '#   Failed test 'My Wibble isa Wibble'
# #   at t/fail-more.t line 248.
# #     My Wibble isn't a class or reference
# '
#   Failed test at t/fail-more.t line 249.
#          got: 'not ok - The class isa Wibble
# '
#     expected: 'not ok - The thing isa Wibble
# '
#   Failed test at t/fail-more.t line 249.
#          got: '#   Failed test 'The class isa Wibble'
# #   at t/fail-more.t line 248.
# #     The class isn't a 'Wibble' it's a ''
# '
#     expected: '#   Failed test 'The thing isa Wibble'
# #   at t/fail-more.t line 248.
# #     The thing isn't a class or reference
# '
t/fail-more.t .............................. Failed 3/80 subtests

@schwern
Copy link
Contributor

schwern commented Apr 12, 2013

On 4/12/13 6:26 PM, Karen Etheridge wrote:

Looks like I didn't test properly this morning, as the new release fails
in t/fail-more.t, and now I can repro this under 5.17.10 on OSX in the
git repo.

Do you have the same problem with a stable Perl?

|t/CanLoad/taint.t .......................... Text::Soundex will be removed from
the Perl core distribution in the next major release. Please install it from CPA
N. It is being used at /Users/ether/git/Test-More/blib/lib/TB2/CanLoad.pm, line 70.

This I'll fix.

@karenetheridge
Copy link
Member Author

Do you have the same problem with a stable Perl?

Negative, all is good there.

(I'm now reminded that there were some semantic changes with how UNIVERSAL::isa works, in the 5.17.* stream. Someone at the hackathon was probably involved and can tell you more.)

@schwern
Copy link
Contributor

schwern commented Apr 13, 2013

Tested on 5.17.10 and yup, the failure is real. See perlbug 105922. Long story short, they made the handling of what is a class name for the purposes of method lookup consistent. Not necessarily correct, just consistent. They patched it in core and it must have slipped through the cracks.

5.17.10.

$ perl -wle 'q[@$%@#$]->foo'
Can't locate object method "foo" via package "@$%@#$" (perhaps you forgot to load "@$%@#$"?) at -e line 1.

5.16.2

$ perl -wle 'q[@$%@#$]->foo'
Can't call method "foo" without a package or object reference at -e line 1.

@ghost ghost assigned schwern Apr 13, 2013
schwern added a commit that referenced this issue Apr 13, 2013
5.17 (and thus 5.18) changes how '#!%@#$!blah'->isa is resolved.  Now
any string will be treated as a class name.  See rt.perl.org #105922

This required changes to the isa_ok() and I decided to overhaul
the logic so it's more organized.  I also changed the formatting,
hopefully more sensibly.

For #353
@schwern
Copy link
Contributor

schwern commented Apr 14, 2013

This is fixed in both master and Test-Builder1.5. 0.98_04 is on CPAN and it'll be in 1.5.0_7.

@schwern schwern closed this as completed Apr 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants