Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtest note at start #364

Merged
merged 3 commits into from Apr 16, 2013
Merged

Subtest note at start #364

merged 3 commits into from Apr 16, 2013

Conversation

schwern
Copy link
Contributor

@schwern schwern commented Apr 15, 2013

Talking with @arc just now, he repeated an oft requested feature that a subtest would be more readable if it had its name at the beginning. I'm resurrecting #290 written by @SineSwiper with the small change that the subtest note is indented with the block.

  1..3
  ok 1 - First test
      # Subtest: An example subtest
      1..2
      ok 1 - This is a subtest
      ok 2 - So is this
  ok 2 - An example subtest
  ok 3 - Third test

PS Contrary to what I thought in #290 a year ago, there is going to be another stable release before 1.5.

@SineSwiper @arc What do you think?

SineSwiper and others added 3 commits April 15, 2013 16:40
Fix t/subtest/*.t to work with new auto-note
Fix outergroup test in t/subtest/predicate.t
Fix Test::Builder::Tester::complaint to not output double-spaced $wanted
@arc
Copy link
Contributor

arc commented Apr 15, 2013

I think this looks great — thanks!

@SineSwiper
Copy link
Contributor

Always happy to see a suggestion/patch make the cut. Now I just need to get around to making a patch to display subtests within TAP::Harness (and possibly prove).

schwern added a commit that referenced this pull request Apr 16, 2013
@schwern schwern merged commit ed077e0 into master Apr 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants