Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook TB2->stream_end() into something #55

Closed
schwern opened this issue Sep 9, 2010 · 1 comment
Closed

Hook TB2->stream_end() into something #55

schwern opened this issue Sep 9, 2010 · 1 comment

Comments

@schwern
Copy link
Contributor

schwern commented Sep 9, 2010

Right now, nothing calls the TB2->stream_end event. You have to call it manually.

It should be called by done_testing().

It should probably be called on DESTROY, configurable, and only if the stream started.

@schwern
Copy link
Contributor Author

schwern commented Jan 9, 2011

DESTROY is a no go. It appears that during global destruction we can't rely on orderly destruction and bits of TB2 are missing by the time it happens.

At the moment it's done in an END block by TB2::Module on the singleton. That seems sensible as in other situations you'll have access to the object itself.

It still may be useful to put it in TB2->DESTROY but I'll wait until there's a use case.

exodist added a commit that referenced this issue Apr 21, 2016
exodist added a commit that referenced this issue Apr 21, 2016
    - No functional changes since the last trial
    - Doc fix (fixes #52)
    - Doc fix (fixes #55)
    - Doc fix in Classic bundle
    - Doc fixes for FromTestBuilder
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant