Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(TO_JSON) Exception event may have a blessed exception #756

Closed
exodist opened this issue Jan 23, 2017 · 0 comments
Closed

(TO_JSON) Exception event may have a blessed exception #756

exodist opened this issue Jan 23, 2017 · 0 comments
Assignees
@exodist

Comments

@exodist
Copy link
Member

exodist commented Jan 23, 2017

Exceptions can be blessed.

Test2::Event::Exception stores the exceptiont hat was thrown. A lot of things throw blessed exceptions. The base class's TO_JSON will choke on this.

For now the best solution may be to have a TO_JSON in the Exception event that simply stringifies the exception as that is all the output does.
@exodist exodist self-assigned this Apr 4, 2017
@exodist exodist mentioned this issue Oct 1, 2017
Closed
@exodist exodist closed this as completed in 0588f12 Oct 3, 2017
exodist added a commit that referenced this issue Oct 3, 2017
@exodist
v1.302097
27bd68f 
    - Fix hub->process bug that could let an error pass
    - Fix #789 (Modification of read only value)
    - Fix typo in Test::Builder when looking for IPC (#777)
    - Fix #791, clone_io broke on scalar io layer
    - Fix #790 and #756, Exception event stingify exception
    - Localize $^E in context (#780)
    - Fix test that failed in verbose mode (#770)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@exodist exodist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@exodist