Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should retry set to true by default #221

Open
georgi-mirchev opened this issue Mar 21, 2023 · 0 comments
Open

Should retry set to true by default #221

georgi-mirchev opened this issue Mar 21, 2023 · 0 comments

Comments

@georgi-mirchev
Copy link

What is this? This InnerWebSocketListener() is not injected but rather created in the OkHttpWebSocketChannel.open() function. This leads to the behavior where shouldRetry is always set to true but there are cases where this should be false. Like a 404 response for an example. Why do you need to retry when the URL cannot be found? This needs to be done in a configurable manner meaning InnerWebSocketListener() should be injected and not created inside the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant