Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"every N days" is ignored when changing weekly task to daily task #1445

Closed
dnrce opened this issue Jun 25, 2014 · 12 comments
Closed

"every N days" is ignored when changing weekly task to daily task #1445

dnrce opened this issue Jun 25, 2014 · 12 comments
Labels
bug 🐛 Problems with the code that result in unexpected or bad behavior
Milestone

Comments

@dnrce
Copy link
Member

dnrce commented Jun 25, 2014

Migrated from the original issue at https://www.assembla.com/spaces/tracks-tickets/tickets/1445

I have some repeating todos that run weekly (every monday, wednesday, ...). I changed those todos so that they run every two days, by setting to "daily" and "every 2 days". This update worked out fine, however the todo is stored with "every 1 day" instead.

Originally reported by carsten.otto on September 9, 2013 at 13:20:04 (-0400) against version 2.2.2

@dnrce
Copy link
Member Author

dnrce commented Jun 25, 2014

On September 9, 2013 at 04:54:27 (-0400), lrbalt commented:

and what happens if you edit the repeat pattern again to set it to every 2 days? does it work then?

@dnrce dnrce added this to the 2.2.3 milestone Jun 25, 2014
@dnrce
Copy link
Member Author

dnrce commented Jun 25, 2014

On September 9, 2013 at 05:31:18 (-0400), carsten.otto commented:

Yes.

@dnrce
Copy link
Member Author

dnrce commented Jul 2, 2014

@C-Otto is this issue still present with the latest Tracks master? The recurring todos got a major refactor somewhat recently.

Edit: Never mind! The refactoring is in 2.3devel and this issue is for 2.2.3.

@C-Otto
Copy link
Contributor

C-Otto commented Jul 3, 2014

Fixed in 9a69b17

I created a new repeating todo, weekly. Changed that to "daily, every 2 days".

@lrbalt
Copy link
Member

lrbalt commented Jul 10, 2014

Closing then :-)

@lrbalt lrbalt closed this as completed Jul 10, 2014
@dnrce
Copy link
Member Author

dnrce commented Jul 10, 2014

@lrbalt That was my mistake -- this issue is in 2.2_branch. @C-Otto retested with master @ 9a69b17 and determined that it's no longer present there, but it's still an open issue for 2.2.3.

@dnrce dnrce reopened this Jul 10, 2014
@lrbalt
Copy link
Member

lrbalt commented Jul 15, 2014

if we release 2.3, we can skip fixing 2.2.x :-)

@dnrce
Copy link
Member Author

dnrce commented Jul 15, 2014

I thought we were perhaps going to do a last 2.2 bugfix release because it's the final version supporting Ruby 1.8.7. But if we're going to have this discussion we should do it on the mailing list. (There was a "release planning" thread on this topic a few months ago.)

@lrbalt
Copy link
Member

lrbalt commented Jul 16, 2014

It was not meant to start a discussion on releasing 2.2 or not :-) I is just that the 2.2 codebase is quite different from 2.3/master and finding and fixing this is not trivial.

@dnrce
Copy link
Member Author

dnrce commented Jul 16, 2014

Actually, I'm pretty sure this was fixed in bd94135. @C-Otto Can you confirm that you don't see it with the latest 2.2_branch?

@C-Otto
Copy link
Contributor

C-Otto commented Jul 16, 2014

My "production" system contains the fix of bd94135 and I cannot reproduce the problem. Feel free to close this ticket :)

@dnrce
Copy link
Member Author

dnrce commented Jul 16, 2014

Thanks for testing!

@dnrce dnrce closed this as completed Jul 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Problems with the code that result in unexpected or bad behavior
Projects
None yet
Development

No branches or pull requests

3 participants