Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded mp4 limitation (make the container to use a user option, including accepting any) #544

Open
GlassedSilver opened this issue Apr 16, 2022 · 2 comments
Labels
FILE MANAGEMENT Things related to file management components is: enhancement New feature or extension of existing functionality meta: good first issue Good for newcomers

Comments

@GlassedSilver
Copy link
Collaborator

GlassedSilver commented Apr 16, 2022

Blocked by #579


Ideally we would always download just what the user wants, e.g. best audio + best video -> merge into whatever container is necessary.

Then for playback transcoding can help if you're on an incompatible client.

This could be avoided by either going with best mp4 as download option or reencoding separately with ffmpeg, but forcing mp4 containers for everyone does have its limits and drawbacks.

Originally posted by @GlassedSilver in #303 (comment)

Relevant error:

ERROR: Postprocessing: file:[FILE PATH AND FILE NAME FOLLOWED BY ".f" and a three digit number like so:].f251.webm: Invalid data found when processing input
@GlassedSilver GlassedSilver changed the title Ideally we would always download just what the user wants, e.g. best audio + best video -> merge into whatever container is necessary. Remove hardcoded mp4 limitation (make container to use a user option, including accepting any) Apr 16, 2022
@GlassedSilver GlassedSilver pinned this issue Apr 16, 2022
@GlassedSilver GlassedSilver added the meta: good first issue Good for newcomers label Apr 16, 2022
@GlassedSilver GlassedSilver added this to To do in v4.3 via automation Apr 17, 2022
@GlassedSilver GlassedSilver added the is: enhancement New feature or extension of existing functionality label Apr 17, 2022
@GlassedSilver
Copy link
Collaborator Author

Urgency decreased due to #551 I think. Let's see how this plays out in the mid-run.

@Tzahi12345
Copy link
Owner

I did try doing this a couple years ago and failed miserably. Lots have changed since then so hopefully it's a tad easier. I do agree this would be a good task for someone to try out and get a feel for the codebase as it touches virtually every part.

I do want to move this to v4.4 as I want to update the latest tag sometime soon.

@GlassedSilver GlassedSilver removed this from To do in v4.3 Apr 24, 2022
@GlassedSilver GlassedSilver added this to To do in v4.4 via automation Apr 24, 2022
@GlassedSilver GlassedSilver added this to the v4.4 milestone Apr 27, 2022
@GlassedSilver GlassedSilver changed the title Remove hardcoded mp4 limitation (make container to use a user option, including accepting any) Remove hardcoded mp4 limitation (make the container to use a user option, including accepting any) Apr 27, 2022
@GlassedSilver GlassedSilver added the FILE MANAGEMENT Things related to file management components label Apr 28, 2022
@GlassedSilver GlassedSilver removed this from To do in v4.4 May 1, 2022
@GlassedSilver GlassedSilver removed this from the v4.4 milestone May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FILE MANAGEMENT Things related to file management components is: enhancement New feature or extension of existing functionality meta: good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants