Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate "Version" #25

Open
bketelsen opened this issue Jan 17, 2023 · 2 comments
Open

Automate "Version" #25

bketelsen opened this issue Jan 17, 2023 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@bketelsen
Copy link
Member

having Version as a string in main.go and also as a file in the repo root is fragile and error-prone. Automate this somehow - simple github action + goreleaser on tag maybe?

@mirkobrombin mirkobrombin added the enhancement New feature or request label Jun 29, 2023
@taukakao
Copy link
Member

Correct me if I'm wrong but as it stands abroot v2 doesn't have versions but instead a continuous release.

@kbdharun
Copy link
Member

Correct me if I'm wrong but as it stands abroot v2 doesn't have versions but instead a continuous release.

The continuous release will be converted to use point release archives upon stable (at that point we will use continuous release in the dev branch of the future release).

Regarding automating releases and uploading of the artifact, I have indeed added a release action a while ago but it doesn't do what bketesen suggests and we need to define the version manually. I explored Goreleaser action 1 for ABRoot repo a while ago (feel free to check the commit log of .github directory) but it caused some issues with our dependencies and didn't perform the release. So this issue is still up for grabs for someone to work on.

Footnotes

  1. We use the same for generating automatic release notes in other repos.

@taukakao taukakao added this to the 2-stable milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To discuss
Development

No branches or pull requests

4 participants