Make SwitchDoesNotHandleAllEnumOptions show lines on the expression. (#531)

Hosch250 · Vannevelj · commit c93cc759df26 · 2016-04-11T20:21:52.000+02:00
* Make SwitchDoesNotHandleAllEnumOptions show lines on the expression.

* Fix cast in code fix.
diff --git a/VSDiagnostics/VSDiagnostics/VSDiagnostics/Diagnostics/General/SwitchDoesNotHandleAllEnumOptions/SwitchDoesNotHandleAllEnumOptionsAnalyzer.cs b/VSDiagnostics/VSDiagnostics/VSDiagnostics/Diagnostics/General/SwitchDoesNotHandleAllEnumOptions/SwitchDoesNotHandleAllEnumOptionsAnalyzer.cs
@@ -82,7 +82,7 @@ private void AnalyzeSymbol(SyntaxNodeAnalysisContext context)
 
                 if (!switchHasSymbol)
                 {
-                    context.ReportDiagnostic(Diagnostic.Create(Rule, switchBlock.GetLocation()));
+                    context.ReportDiagnostic(Diagnostic.Create(Rule, switchBlock.Expression.GetLocation()));
                     return;
                 }
             }
diff --git a/VSDiagnostics/VSDiagnostics/VSDiagnostics/Diagnostics/General/SwitchDoesNotHandleAllEnumOptions/SwitchDoesNotHandleAllEnumOptionsCodeFix.cs b/VSDiagnostics/VSDiagnostics/VSDiagnostics/Diagnostics/General/SwitchDoesNotHandleAllEnumOptions/SwitchDoesNotHandleAllEnumOptionsCodeFix.cs
@@ -40,7 +40,7 @@ private async Task<Solution> AddMissingCaseAsync(Document document, CompilationU
         {
             var semanticModel = await document.GetSemanticModelAsync();
 
-            var switchBlock = (SwitchStatementSyntax) statement;
+            var switchBlock = (SwitchStatementSyntax) statement.Parent;
 
             var enumType = (INamedTypeSymbol) semanticModel.GetTypeInfo(switchBlock.Expression).Type;
             var caseLabels = switchBlock.Sections.SelectMany(l => l.Labels)

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ private void AnalyzeSymbol(SyntaxNodeAnalysisContext context)`
`82`	`82`
`83`	`83`	`if (!switchHasSymbol)`
`84`	`84`	`{`
`85`		`- context.ReportDiagnostic(Diagnostic.Create(Rule, switchBlock.GetLocation()));`
	`85`	`+ context.ReportDiagnostic(Diagnostic.Create(Rule, switchBlock.Expression.GetLocation()));`
`86`	`86`	`return;`
`87`	`87`	`}`
`88`	`88`	`}`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ private async Task<Solution> AddMissingCaseAsync(Document document, CompilationU`
`40`	`40`	`{`
`41`	`41`	`var semanticModel = await document.GetSemanticModelAsync();`
`42`	`42`
`43`		`- var switchBlock = (SwitchStatementSyntax) statement;`
	`43`	`+ var switchBlock = (SwitchStatementSyntax) statement.Parent;`
`44`	`44`
`45`	`45`	`var enumType = (INamedTypeSymbol) semanticModel.GetTypeInfo(switchBlock.Expression).Type;`
`46`	`46`	`var caseLabels = switchBlock.Sections.SelectMany(l => l.Labels)`