Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fishing rod displays incorrectly with versions 1.10.x and lower #3762

Open
zivoric opened this issue Mar 28, 2024 · 4 comments
Open

Fishing rod displays incorrectly with versions 1.10.x and lower #3762

zivoric opened this issue Mar 28, 2024 · 4 comments
Assignees
Labels
Legacy Very low priority, but prs are still welcome

Comments

@zivoric
Copy link

zivoric commented Mar 28, 2024

General Information

https://dump.viaversion.com/6a455e63a58df72754074334382718be5ddb5d74623f90392838b2f03bf66a44

Bug Description

When playing on servers with version 1.10.x or lower, the position of the fishing bobber displayed client-side seems to not match with where it is on the server. A video is attached displaying this behavior, which becomes apparent when actually catching a fish.

2024-03-28.15-32-48.mp4

Steps to Reproduce

  1. Join server with version 1.10.x or lower (tested 1.8.x, 1.9.3-4, and 1.10.x; 1.11.1-2 displays the correct behavior)
  2. Get a fishing rod and throw the bobber (into water)
  3. Fishing bobber is in incorrect position, as seen by the particles appearing in a different position from where the bobber appears to be

Expected Behavior

Fishing bobber should display with the correct physics client-side for the version the server is running

@zivoric zivoric added the Bug Confirmed bug label Mar 28, 2024
@FlorianMichael
Copy link
Member

Hi there, thanks for reporting this issue and giving us a detailed description about it, can you please try to remove all mods except ViaFabricPlus and see if it still occurs? Also it would be helpful if you could test out the ViaProxy (https://github.com/ViaVersion/ViaProxy) and see if the issue also appears using that, you'll find detailed instructions on how to use it on the GitHub README

@zivoric
Copy link
Author

zivoric commented Mar 28, 2024

I tested it without any mods except for ViaFabricPlus and it is still the same. As for ViaProxy, I ran vanilla Minecraft 1.20.4 with ViaProxy and it also displays incorrectly. Maybe ViaFabricPlus isn't at fault, but either way, it seems like the fishing rod is displayed according to 1.11+ behavior to the user even when the server is 1.10 or lower.

@FlorianMichael
Copy link
Member

Thanks for your testing, seems to be an ViaVersion issue then, I'll investigate this at some point.

@FlorianMichael FlorianMichael transferred this issue from ViaVersion/ViaFabricPlus Mar 28, 2024
@FlorianMichael FlorianMichael self-assigned this Mar 28, 2024
@kennytv kennytv added Legacy Very low priority, but prs are still welcome and removed Bug Confirmed bug labels Mar 28, 2024
@gre3x
Copy link

gre3x commented Mar 31, 2024

I am also getting this issue (Paper 1.8.8 with ViaVersion running on backend server). My 1.12+ servers have no issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Legacy Very low priority, but prs are still welcome
Projects
None yet
Development

No branches or pull requests

4 participants