Skip to content

Commit 56fe90a

Browse files
committed
Clean up the FIXMEs that are already done
1 parent 85c6905 commit 56fe90a

File tree

4 files changed

+4
-9
lines changed

4 files changed

+4
-9
lines changed

src/main/java/de/vogel612/helper/data/OverviewModel.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,8 @@ private Document parseFile(final Path path) {
122122
doc = documentBuilder.build(path.toFile());
123123
return doc;
124124
} catch (JDOMException e) {
125-
// FIXME: Get the presenter out of error-handling!
126-
// presenter.onException(e, "Unspecified Parsing error");
127125
throw new IllegalStateException("Unable to parse " + xmlFile, e);
128126
} catch (IOException e) {
129-
// presenter.onException(e, "Unspecified I/O Error");
130127
throw new UncheckedIOException("Unable to read" + xmlFile, e);
131128
}
132129
}

src/main/java/de/vogel612/helper/data/util/DataUtilities.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
* Centralizes access to data processing for {@link de.vogel612.helper.data.OverviewModel} and other classes that
2020
* benefit from the abstraction
2121
*/
22-
// FIXME write unit-tests
2322
public class DataUtilities {
2423
public static final String SINGLE_TRUTH_LOCALE = "";
2524

src/main/java/de/vogel612/helper/ui/jfx/JFXResxChooserController.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ protected void onFilesetChangeInternal() {
7272

7373
private void showLocaleDialog(Consumer<String> callback) {
7474
final String[] localeChoices = localeOptionCache.toArray(new String[localeOptionCache.size()]);
75-
// FIXME rewrite as JavaFX dialog
7675
ChoiceDialog<String> dialog = new ChoiceDialog<>(localeChoices[0], localeChoices);
7776
dialog.setHeaderText("Choose a Language");
7877
dialog.setContentText("");
@@ -85,13 +84,12 @@ private void showLocaleDialog(Consumer<String> callback) {
8584

8685
@Override
8786
public void hide() {
88-
87+
throw new UnsupportedOperationException();
8988
}
9089

9190
@Override
92-
// FIXME probably need to get that into presenter
9391
public void show() {
94-
92+
throw new UnsupportedOperationException();
9593
}
9694

9795
@Override

src/main/java/de/vogel612/helper/ui/jfx/JFXTranslationController.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,12 @@ public void initialize(URL url, ResourceBundle resourceBundle) {
7373
if (evt.isShiftDown()) {
7474
input.setText(input.getText() + "\r\n");
7575
} else {
76-
submit.fire(); // FIXME verify?
76+
submit.fire();
7777
}
7878
evt.consume();
7979
} else if (evt.getCode() == KeyCode.ESCAPE) {
8080
cancel.fire();
81+
evt.consume();
8182
}
8283
// should keep bubbling to default handler
8384
});

0 commit comments

Comments
 (0)