Actual function tests for the Overview, One stupid test case for ResxChooser and a stab at useful tests for Translation view

Author: Vogel612

src/main/java/de/vogel612/helper/ui/ResxChooser.java

@@ -56,6 +56,12 @@ public ResxChooser() {
         window.add(chooseFileset);
         window.add(submit);
 
+        // unit-test related
+        submit.setName("submit");
+        chooseFileset.setName("fileset");
+        rightLocaleChange.setName("right");
+        leftLocaleChange.setName("left");
+
         fileChooser.setFileFilter(new FileNameExtensionFilter("Resx files", "resx"));
         fileChooser.setMultiSelectionEnabled(false);
         fileChooser.setDialogTitle("Choose a resx file kind to translate");
@@ -89,7 +95,9 @@ public ResxChooser() {
 
     public void setFileset(Path fileset) {
         this.fileset = fileset;
-        onFilesetChange();
+        if (fileset != null) { // FIXME should we even allow null??
+            onFilesetChange();
+        }
     }
 
     private void onFilesetChange() {

src/test/java/de/vogel612/helper/ui/OverviewViewTests.java

@@ -1,28 +1,39 @@
 package de.vogel612.helper.ui;
 
+import static junit.framework.Assert.assertEquals;
 import static org.assertj.swing.finder.WindowFinder.findFrame;
 import static org.mockito.Matchers.any;
+import static org.mockito.Matchers.eq;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.verifyNoMoreInteractions;
 
 import org.assertj.swing.core.GenericTypeMatcher;
+import org.assertj.swing.data.TableCell;
 import org.assertj.swing.edt.FailOnThreadViolationRepaintManager;
 import org.assertj.swing.fixture.FrameFixture;
 import org.assertj.swing.junit.testcase.AssertJSwingJUnitTestCase;
 import org.junit.Before;
 import org.junit.Test;
 
-import javax.swing.*;
+import de.vogel612.helper.data.Translation;
+
 import java.awt.*;
 import java.awt.event.WindowEvent;
+import java.util.Arrays;
 import java.util.function.Consumer;
 
 /**
  * Created by vogel612 on 26.01.16.
  */
 public class OverviewViewTests extends AssertJSwingJUnitTestCase {
 
+    private static final Translation[] dataLeft = new Translation[] {
+      new Translation("", "key", "value"), new Translation("", "another_key", "some better value")
+    };
+    private static final Translation[] dataRight = new Translation[] {
+      new Translation("ts", "key", "something"), new Translation("ts", "another_key", "awesome value")
+    };
     private FrameFixture frame;
 
     private OverviewView cut;
@@ -41,6 +52,8 @@ protected void onSetUp() {
         windowClosingListener = mock(Consumer.class);
         translationReqListener = mock(Consumer.class);
         langReqListener = mock(Runnable.class);
+
+        robot().settings().delayBetweenEvents(20);
     }
 
     @Before
@@ -51,6 +64,8 @@ public void before() {
         cut.addWindowClosingListener(windowClosingListener);
         cut.addTranslationRequestListener(translationReqListener);
         cut.addLanguageRequestListener(langReqListener);
+
+        cut.rebuildWith(Arrays.asList(dataLeft), Arrays.asList(dataRight));
         cut.show();
 
         frame = findFrame(new GenericTypeMatcher<Frame>(Frame.class) {
@@ -87,5 +102,25 @@ public void closingWindow_firesWindowClosingListener() {
         verifyNoMoreInteractions(saveReqListener, windowClosingListener, translationReqListener, langReqListener);
     }
 
-    // FIXME need some translation table tests
+    @Test
+    public void table_containsCorrectRows() {
+        assertEquals(dataLeft.length, frame.table().rowCount());
+
+        verifyNoMoreInteractions(saveReqListener, windowClosingListener, translationReqListener, langReqListener);
+    }
+
+    @Test
+    public void tableClick_doesNothing() {
+        frame.table().cell(TableCell.row(0).column(1)).click();
+
+        verifyNoMoreInteractions(saveReqListener, windowClosingListener, translationReqListener, langReqListener);
+    }
+
+    @Test
+    public void tableDoubleClick_firesTranslationReqListener() {
+        frame.table().cell(TableCell.row(0).column(1)).doubleClick();
+
+        verify(translationReqListener).accept(eq("key"));
+        verifyNoMoreInteractions(saveReqListener, windowClosingListener, translationReqListener, langReqListener);
+    }
 }

src/test/java/de/vogel612/helper/ui/ResxChooserTests.java

@@ -1,7 +1,60 @@
 package de.vogel612.helper.ui;
 
+import static org.assertj.swing.finder.WindowFinder.findFrame;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verifyNoMoreInteractions;
+
+import org.assertj.swing.core.GenericTypeMatcher;
+import org.assertj.swing.edt.FailOnThreadViolationRepaintManager;
+import org.assertj.swing.fixture.FrameFixture;
+import org.assertj.swing.junit.testcase.AssertJSwingJUnitTestCase;
+import org.junit.Before;
+import org.junit.Test;
+import de.vogel612.helper.ui.ResxChooser.ResxChooserEvent;
+
+import java.awt.*;
+import java.nio.file.Paths;
+import java.util.function.Consumer;
+
 /**
  * Created by vogel612 on 26.01.16.
  */
-public class ResxChooserTests {
+public class ResxChooserTests extends AssertJSwingJUnitTestCase {
+
+    private ResxChooser cut;
+
+    private Consumer<ResxChooserEvent> listener;
+    private FrameFixture frame;
+
+
+    @Override
+    protected void onSetUp() {
+        FailOnThreadViolationRepaintManager.uninstall();
+
+        listener = mock(Consumer.class);
+        robot().settings().delayBetweenEvents(20);
+    }
+
+    @Before
+    public void before() {
+        cut = new ResxChooser();
+        cut.addCompletionListener(listener);
+        cut.setFileset(Paths.get(getClass().getResource("RubberduckUI.resx").getFile()));
+        cut.show();
+
+        frame = findFrame(new GenericTypeMatcher<Frame>(Frame.class){
+            @Override
+            protected boolean isMatching(Frame component) {
+                return component.isShowing();
+            }
+        }).using(robot());
+    }
+
+    @Test
+    public void submitButton_withUnselectedPath_doesNothing() {
+        cut.setFileset(null);
+        frame.button("submit").click();
+
+        verifyNoMoreInteractions(listener);
+    }
 }

src/test/java/de/vogel612/helper/ui/TranslationPresenterTests.java

@@ -3,9 +3,7 @@
 import static org.assertj.swing.finder.WindowFinder.findFrame;
 import static org.mockito.Matchers.any;
 import static org.mockito.Matchers.eq;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.verifyNoMoreInteractions;
+import static org.mockito.Mockito.*;
 
 import org.assertj.swing.core.GenericTypeMatcher;
 import org.assertj.swing.edt.FailOnThreadViolationRepaintManager;
@@ -37,14 +35,16 @@ protected void onSetUp() {
 
         abortListener = mock(Runnable.class);
         submitListener = mock(Consumer.class);
+
+        robot().settings().delayBetweenEvents(20);
     }
 
     @Before
     public void before() {
         cut = new TranslationPresenter();
         cut.addTranslationAbortListener(abortListener);
         cut.addTranslationSubmitListener(submitListener);
-        cut.setRequestedTranslation(new Translation("","",""), new Translation("","",""));
+        cut.setRequestedTranslation(new Translation("", "", ""), new Translation("", "", ""));
         cut.show();
 
         frame = findFrame(new GenericTypeMatcher<Frame>(Frame.class) {
@@ -64,6 +64,18 @@ public void abortButton_firesAbortListener() {
         verifyNoMoreInteractions(abortListener, submitListener);
     }
 
+    @Test
+    public void settingTranslation_fillsRelevantUI() {
+        cut.setRequestedTranslation(new Translation("src", "key", "original"),
+          new Translation("target", "key", "current"));
+
+        frame.textBox().requireText("current");
+        frame.textBox().requireEditable();
+        frame.label().requireText("original");
+        // FIXME verify title
+        verifyNoMoreInteractions(abortListener, submitListener);
+    }
+
     @Test
     public void submitButton_firesSubmitListener() {
         frame.button("submit").click();