Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(colors): Rework color palette to better match accent color #1641

Merged
merged 14 commits into from
May 29, 2024

Conversation

Larsluph
Copy link
Collaborator

@Larsluph Larsluph commented Apr 13, 2024

Navbar color has been darkened
image

Also added a redesigned variant to better match the app's visual identity.
image

With all that, light and dark mode now has an option to specify which variant you want
image

Colors handling also moved to plain TS for better support of theme in the future as it will allow for fully customizable theme colors.

BTW torrent card sideborders are fixed in that PR.

Fixes #1639

@Larsluph Larsluph self-assigned this Apr 13, 2024
@Larsluph Larsluph requested a review from WDaan as a code owner April 13, 2024 09:33
@WDaan
Copy link
Collaborator

WDaan commented Apr 15, 2024

Personally not a big fan of the greenish hue that would be over everything.
I do agree that the current color palet could be tweaked/improved upon.

Seems like this issue is not being super upvoted by everybody, so perhaps this should be more of a public vote?

We could also make it customizable but I'm a bit afraid of the tech debt overhead that could/would generate.

@Larsluph
Copy link
Collaborator Author

Larsluph commented Apr 15, 2024

Seems like this issue is not being super upvoted by everybody, so perhaps this should be more of a public vote?

Totally agree with that, no idea how we could achieve that? On discord maybe? I heard they are currently releasing a polling system, we could try it.

We could also make it customizable but I'm a bit afraid of the tech debt overhead that could/would generate.

Adding several color palettes in the interface could be possible thanks to vuetify's theme customization. I don't think it's possible to make it fully customizable though, only predefined palettes...

@Larsluph
Copy link
Collaborator Author

@WDaan for this would you prefer a toggle to enable these alternative colors, or making a poll to replace the existing palette?

@WDaan
Copy link
Collaborator

WDaan commented Apr 29, 2024

I guess we could use Discord for some community input? What would they like to see changed? Maybe some minor adjustments are sufficient to resolve the issue. Nobody else has commented on it or posted a reaction.

@WDaan
Copy link
Collaborator

WDaan commented May 9, 2024

Allright guess both will exist, and they will be slightly tweaked over time

@Larsluph Larsluph marked this pull request as draft May 9, 2024 11:26
@Larsluph Larsluph force-pushed the perf/colors branch 2 times, most recently from 8c23ef2 to 80e38df Compare May 25, 2024 16:19
@Larsluph Larsluph marked this pull request as ready for review May 25, 2024 16:22
@WDaan
Copy link
Collaborator

WDaan commented May 28, 2024

Screenshot 2024-05-28 at 09 32 44

Personally, I like the green on the old version of the chart more. I agree the background of the sidebar could be a little darker but this current tint is a bit too dark for my taste. Or perhaps I'm just so used of seeing the old theme 😅

The redesigned theme is cool, but I fail to see how it's easier to read. Also I think the legacy theme should remain the default? 🤔

@Larsluph
Copy link
Collaborator Author

Larsluph commented May 28, 2024

Personally, I like the green on the old version of the chart more.

The green on the right is the correct one for the legacy theme.
The green on the left is for the redesigned theme. I might have copy-pasted too quickly or I didn't understand what you said 🤔

I agree the background of the sidebar could be a little darker but this current tint is a bit too dark for my taste. Or perhaps I'm just so used of seeing the old theme 😅

Totally agree but this dark tint is for fixing the initial issue, unless we keep it the same as before if we assume that the issue isn't relevant...

The redesigned theme is cool, but I fail to see how it's easier to read.

Redesigned theme was just something I had in mind to keep a monochromatic color scheme throughout the UI. It doesn't have any added value.

Also I think the legacy theme should remain the default? 🤔

Forgot to change it back after debugging 😅

@WDaan
Copy link
Collaborator

WDaan commented May 29, 2024

Screenshot 2024-05-29 at 19 26 18

Thanks for adjusting! This does look better.

Copy link
Collaborator

@WDaan WDaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 great!

@Larsluph Larsluph merged commit 6a20007 into master May 29, 2024
1 check passed
@Larsluph Larsluph deleted the perf/colors branch May 29, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Darken drawer background
2 participants