-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(colors): Rework color palette to better match accent color #1641
Conversation
Personally not a big fan of the greenish hue that would be over everything. Seems like this issue is not being super upvoted by everybody, so perhaps this should be more of a public vote? We could also make it customizable but I'm a bit afraid of the tech debt overhead that could/would generate. |
Totally agree with that, no idea how we could achieve that? On discord maybe? I heard they are currently releasing a polling system, we could try it.
Adding several color palettes in the interface could be possible thanks to vuetify's theme customization. I don't think it's possible to make it fully customizable though, only predefined palettes... |
@WDaan for this would you prefer a toggle to enable these alternative colors, or making a poll to replace the existing palette? |
I guess we could use Discord for some community input? What would they like to see changed? Maybe some minor adjustments are sufficient to resolve the issue. Nobody else has commented on it or posted a reaction. |
Allright guess both will exist, and they will be slightly tweaked over time |
8c23ef2
to
80e38df
Compare
The green on the right is the correct one for the legacy theme.
Totally agree but this dark tint is for fixing the initial issue, unless we keep it the same as before if we assume that the issue isn't relevant...
Redesigned theme was just something I had in mind to keep a monochromatic color scheme throughout the UI. It doesn't have any added value.
Forgot to change it back after debugging 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 great!
Navbar color has been darkened
![image](https://private-user-images.githubusercontent.com/22910497/333850623-75b8d6b7-416f-4d22-9695-2455a7be8a97.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgzODY3MjAsIm5iZiI6MTcxODM4NjQyMCwicGF0aCI6Ii8yMjkxMDQ5Ny8zMzM4NTA2MjMtNzViOGQ2YjctNDE2Zi00ZDIyLTk2OTUtMjQ1NWE3YmU4YTk3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE0VDE3MzM0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJiMjNmMGU3YzI4OGI1YWNkODczMjYwOWQyZGRhNmIzYjhjNDQ2ZTdmOThlOTJkY2FjMzZhMWE1YjlkOGRkZDcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.kzhWbkorcwZPKgA0NLsxRfXXXqgu5AH8eVKKEGXj9IM)
Also added a redesigned variant to better match the app's visual identity.
![image](https://private-user-images.githubusercontent.com/22910497/333850675-008c07e0-9050-47bd-828b-345f4461c088.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgzODY3MjAsIm5iZiI6MTcxODM4NjQyMCwicGF0aCI6Ii8yMjkxMDQ5Ny8zMzM4NTA2NzUtMDA4YzA3ZTAtOTA1MC00N2JkLTgyOGItMzQ1ZjQ0NjFjMDg4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE0VDE3MzM0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQxNDU0NjljMmFhOGI2NjIzZjc3YWY0Y2Y0NzgxMjgwMGQxYTIyN2UwN2YwNzM3ZmNlZTQ2NjhlMWZiYzE3NWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.9AjGfU4XDolmks4O2nnmVatUDSd3TAQKS8EoiGS66go)
With all that, light and dark mode now has an option to specify which variant you want
![image](https://private-user-images.githubusercontent.com/22910497/333867214-36c8f90b-5241-4e2f-aded-c335faaf6edb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgzODY3MjAsIm5iZiI6MTcxODM4NjQyMCwicGF0aCI6Ii8yMjkxMDQ5Ny8zMzM4NjcyMTQtMzZjOGY5MGItNTI0MS00ZTJmLWFkZWQtYzMzNWZhYWY2ZWRiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE0VDE3MzM0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI1MTA3NTdlMjJmYzMyYTBhZmU1OTU5Y2Y4N2Y2ZWE2MDYyMjc1MTA3ZGZkMWU4ZGFlYjQ4MmNjNTZhZTJiODMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.arB9zbpYx1ERABdLpr57N6adYmyKXJjXo3NhAnyHia0)
Colors handling also moved to plain TS for better support of theme in the future as it will allow for fully customizable theme colors.
BTW torrent card sideborders are fixed in that PR.
Fixes #1639