Preventing infinite loop #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the remote URL is generated automatically in the theme, it may be even empty. In such case there is an infinite PHP loop produced, which causes memory error. These changes prevent infinite loop from happening.
aristath
requested changes
Apr 30, 2024
wptt-webfont-loader.php
Outdated
| @@ -474,7 +489,7 @@ protected function write_stylesheet() { | |||
|
|
|||
| // If we got this far, we need to write the file. | |||
| // Get the CSS. | |||
| if ( ! $this->css ) { | |||
| if ( is_null( $this->css ) ) { | |||
There was a problem hiding this comment.
Suggested change
| if ( is_null( $this->css ) ) { | |
| if ( null === $this->css ) { |
There was a problem hiding this comment.
Hi @aristath Can you please explain the reason for this change?
There was a problem hiding this comment.
In WordPress Core we've already replaced all instances of is_null with strict null === $x checks.
The reason behind that change was performance (strict checks are faster than an is_null call), as well as readability and consistency 👍
There was a problem hiding this comment.
Thanks for clarification. I've updated the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the remote URL is generated automatically in the theme, it may even be empty.
In such case there is an infinite PHP loop produced, which causes memory error.
These changes prevent infinite loop from happening.
Fixes #24