Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] modal.subscribeEvents returns CONNECT_SUCCESS event after wallet rejects connection #2143

Open
hcote opened this issue Apr 11, 2024 · 1 comment
Open

[bug] modal.subscribeEvents returns CONNECT_SUCCESS event after wallet rejects connection #2143

hcote opened this issue Apr 11, 2024 · 1 comment
Labels
bug Something isn't working needs review

Comments

@hcote
Copy link

hcote commented Apr 11, 2024 •
edited

Link to minimal reproducible example

https://codesandbox.io/p/sandbox/blazing-wave-8pymf7

Summary

When the web3modal opens and a user clicks MetaMask, if a user rejects the MetaMask connection, modal.subscribeEvents returns a CONNECT_SUCCESS event, I believe it should be CONNECT_ERROR.

See the codesandbox to reproduce.

Screenshot 2024-04-11 at 2 15 07 PM

List of related npm package versions

ethers@5.7.2
@web3modal/ethers5@4.1.6
@hcote hcote added bug Something isn't working needs review labels Apr 11, 2024
@linear Linear
Copy link

linear bot commented Apr 11, 2024

W3M-240 [bug] `modal.subscribeEvents` returns `CONNECT_SUCCESS` event after wallet rejects connection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hcote