Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Customize all WalletConnect options while initialize createModal #2172

Open
yulafezmesi opened this issue Apr 22, 2024 · 6 comments

Comments

@yulafezmesi
Copy link

What problem does this new feature solve?

as far as i can see, currently not possible to pass optionalMethods and all other optiona to initialize walletconnect eth. provider. can we make this possible?

https://github.com/WalletConnect/web3modal/blob/V4/packages/ethers5/src/client.ts#L383

Describe the solution you'd like

create a new contractor object named like ethereumProviderOptions, and pass into walletconnect eth. provider.

private ethereumProviderOptions: EthereumProviderOptions | undefined = undefined

@glitch-txs
Copy link
Member

Is there any particular method you'd like to add? We add all the Ethereum methods by default

@yulafezmesi
Copy link
Author

yulafezmesi commented Apr 22, 2024

we have special integration with Avocado Wallet and Avocado handling custom methods like avocado_getOwner or avocado_sendTransaction. this was possible with legacy Web3Modal, but currently is not possible. (we're migrating to v4)

edit: if i don't pass the optional method names, throwing method not found err

image

@glitch-txs
Copy link
Member

Ahh this is only supported when used with Wagmi atm

@yulafezmesi
Copy link
Author

i see. can be possible for ethers5 as well? i'm willing to created PR if sounds good you.

@glitch-txs
Copy link
Member

we will refactor the connectors logic, once that's done we can add it I think.

cc @svenvoskamp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants