Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported chains pops up after SIWE signing #2180

Open
LucyTrump0x opened this issue Apr 23, 2024 · 1 comment
Open

Unsupported chains pops up after SIWE signing #2180

LucyTrump0x opened this issue Apr 23, 2024 · 1 comment
Labels
bug Something isn't working Customer Support

Comments

@LucyTrump0x
Copy link

LucyTrump0x commented Apr 23, 2024

What problem does this new feature solve?

What I mean is that this situation arises after integrating SiweConfig.
The current issue is that the sign dialog pops up without checking if the chainId is supported. Moreover, there are no hooks or callbacks provided for customizing the sign, which leads to a situation where after signing, it checks for unsupported chains, prompts to switch chains, and then requires signing again. This is unreasonable and unfriendly.

Describe the solution you'd like

Before executing the Siwe signature, it is necessary to check if the chainId is in the chains list. If it is not in the list, prompt to switch the chain first, or automatically switch to the default chain before executing the signature.

Copy link

linear bot commented Apr 23, 2024

W3M-274 [feature]

@glitch-txs glitch-txs added bug Something isn't working and removed feature-request needs review labels Apr 23, 2024
@glitch-txs glitch-txs changed the title [feature] Unsupported chains pops up after SIWE signing Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Customer Support
Projects
None yet
Development

No branches or pull requests

2 participants