Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Post #4

Closed
Xarcell opened this issue Jan 31, 2014 · 5 comments
Closed

New Post #4

Xarcell opened this issue Jan 31, 2014 · 5 comments
Assignees
Labels

Comments

@Xarcell
Copy link

Xarcell commented Jan 31, 2014

When I make a reply to a post, then go to the index, it shows there is a new post made the the category where I just made a post.

So in the board index, it indicates my post as a new unread post in that board, but when I get to the message index, there is no indication that my post was a new post. I'm pretty sure this is undesired.

@Nao
Copy link
Member

Nao commented Jan 31, 2014

Can you post screenshots..? Because I'm not sure I get what you mean.

I don't use the board index much personally; it's only there because people expect it. Otherwise, I'd have replaced it with something different.

@Xarcell
Copy link
Author

Xarcell commented Jan 31, 2014

Here's what I did. Installed Wedge. Viewed the only topic there was(welcome topic). Went back to the index(home). The "General Discussion" icon indicated no new posts. So far so good.

Then I went back to the "Welcome" topic. Made a "test reply". Went back to the index(home), and the "General Discussion" icon indicated there was a new unread post. WHY? SMF doesn't so this.

It's basically telling me that there is a new unread post in the "General Discussion" board, but it's my post, why is it telling me my post is a new unread post. I already know what it says. However, let's say that hypothetically that was intentional design, because I didn't view my post after making it(was redirected to the message index as normal). Inconsistency is that the board icon indicates a new post, but when you view the topic list within that board, no topic has a "new" next to it, indicating if there was a new post or not.

A screenshot will not help explain the issue here. If I still didn't explain it well, try to duplicate the issue. maybe then you'll catch it.

1.| Make sure you have no unread posts.
2.| Reply to a topic.
3.| Go "home". You should see the board in which you just made a post indicate there is a new post.
4A.| Click "unread posts" for that board category. You'll notice that it is empty.
4B.| Or just click on the board indicating a new post, from there it will not say which topic as the new post.

@Nao
Copy link
Member

Nao commented Feb 5, 2014

Okay, I can reproduce this...

It's a bit complicated, though. Board icon status is set by, basically, 'seen' status in a board, which is different from seen status in a topic. Wedge marks a topic as read when you post to it, but it doesn't mark the board as read if all topics are read in it. In fact, SMF never really bothers with that either, as all posts sent prior to your registration are considered read but Wedge still allows you to read them.

Strike that, it's not "a bit complicated", it's just... One of the many aspects of SMF/Wedge which I don't like, and thus haven't looked much into. Not only that, but noisen.com got rid of board status icons back in 2007, and nobody ever complied to me about these. People I know do not use these icons, they instead use either 'recent posts' or 'unread posts/unread replies', or simply navigate to folders, or look up the 'last post by...' entries in board lists. But I've never heard of them being confused by the lock of a board status icon. Instead, they've always been happy that they can create their own boards and choose the icons for them. (I could technically turn these icons into on/off states, but as I said, nobody ever complained, so why bother..?)

If you can come up with a non-expensive solution, I'd be interested. In the meantime, I'm just surprised that it doesn't work this way in SMF 2.0, because that's where the code was taken from, and I didn't change a LOT of it.

@Xarcell
Copy link
Author

Xarcell commented Feb 5, 2014

I've tested this in Elk & SMF, it does not have this problem, or at least I cannot duplicate the issue.

For someone like me, I never use "unread posts", or the "last post by". I dunno why, I just never felt comfortable using it.

If's it's not broken, then don't worry about it. I just find it mis-leading by making me think there is a new post in that board. Overall, I've never been fond of the whole board status icons anyway. I'd much rather see a different icon per board with a indication of the number of "new topics" in that board.

I dunno, there's just so many things I think should be dramatically different about forum software. Traditional designs are holding forum software back, just like how IE6 held back web design. That's why forums are dying. I find it so frustrating. I've spent all week searching the web for a software that best fits my clients & I needs, and build from that. So far, I'm come up completely empty-handed. There is nothing even close. The best thing for me to do is fork SMF 2.1, but then I'm not a developer and I can only take it so far. :: end rant ::

Sorry to ranting, wedge is a good product.

FYI, that slowness issue is as we discussed at Elkarte is my server setup. I experience the same hanging with SMF 2.1, Pligg, Oxwall, Dolphin, over the past week, but not with Elkarte for some reason.

@Nao Nao added the bug label Apr 3, 2014
@Nao Nao self-assigned this Apr 3, 2014
@Nao
Copy link
Member

Nao commented Apr 3, 2014

Not that I'm expecting you to read this, but I'm marking the bug as fixed. I actually removed the offending code, and replaced it with a better version.

  • Board icons opacity now indicates the date of the most recent post (just like the "last post" column).
  • Number of unread posts is now shown directly next to the board name, including in sub-boards. It's slower of course, and I'll need to add caching for that, but for now it's fine.

@Nao Nao closed this as completed Apr 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants