Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Real Type #495

Closed
DavePearce opened this issue Jun 4, 2015 · 2 comments
Closed

Removing Real Type #495

DavePearce opened this issue Jun 4, 2015 · 2 comments
Assignees
@DavePearce
Labels
Feature Thoughts
Milestone
v0.3.38

Comments

@DavePearce
Copy link
Member

An interesting idea is the removal of the real type. The major points here are:

  1. We don't want a single real type. Rather, we want a fraction, a decimal, float, etc.

  2. We can avoid ambiguous casts. This may or may not be true.

  3. This further simplifies the language.

  4. We can still retain decimal constant literals. I think we definitely want to keep these.

  5. But, how does this affect verification. For example, how do we specify floating point operations?
@DavePearce DavePearce added this to the ChangeList Post v0.4.0 milestone Jun 4, 2015
@DavePearce DavePearce mentioned this issue Jun 4, 2015
Closed
@DavePearce
Copy link
Member Author

Realistically, for now it doesn't matter. I think it makes a lot of sense to remove this type, and then restore it at a later date (if appropriate).

@DavePearce DavePearce mentioned this issue Jan 26, 2016
Closed
DavePearce added a commit that referenced this issue Jan 28, 2016
@DavePearce
Removed Real Type #495
3ca421e 
This removes the real type from WyC, WyIL and WyJC.  This is a fairly
major change, but was pretty easy to do.  The remain jobs are to update
the test cases and standard library.
DavePearce added a commit that referenced this issue Jan 28, 2016
@DavePearce
Remove real type from standard library #495
9d348a3 
This removes all functions which previously operated on the real data
type, including any related constants (such as PI).
DavePearce added a commit that referenced this issue Jan 28, 2016
@DavePearce
Remove or update tests involved real #495
2bc0edc 
This removes or updates tests involving the real data type which is now
removed, given that the real type has now been removed.

In some cases, I may have been overzealous in removing some valid tests
and I should revisit this.
DavePearce added a commit that referenced this issue Jan 28, 2016
@DavePearce
Remove or update test cases involving real #495
e69c85b 
This removes or updates test cases which involve the real data type that
has recently been removed.  Where possible, I have adjust test cases to
use alternative types, like bool, byte or int.  In some cases, however,
I felt there was no useful alternative.
@DavePearce DavePearce mentioned this issue Jan 28, 2016
Closed
@DavePearce
Copy link
Member Author

Done. Need to remove cast operator now #576.

@DavePearce DavePearce self-assigned this Jan 28, 2016
This was referenced Jan 28, 2016
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavePearce DavePearce

Labels
Feature Thoughts
Projects
None yet
Milestone
v0.3.38
Development

No branches or pull requests
1 participant
@DavePearce