Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip deleted observations in SAS7BDAT files #284

Open
peiyaoli2 opened this issue Sep 29, 2022 · 10 comments
Open

Skip deleted observations in SAS7BDAT files #284

peiyaoli2 opened this issue Sep 29, 2022 · 10 comments

Comments

@peiyaoli2
Copy link

Hi, it seems like ReadStat also has a similar issue as pandas-dev/pandas#15963, where deleted observations are still being counted in rows & being read. Here is a sample output from ReadStat on the same file as the other issue:

readstat /Users/peiyao.li/Downloads/datetime.sas7bdat
Format: SAS data file (SAS7BDAT)
Columns: 5
Rows: 5
Table name: DATETIME
Format version: 8
Text encoding: WINDOWS-1252
Byte order: little-endian
Timestamp: 08 Apr 2017 09:51

And the screenshot from the other thread is shown that there are 3 rows and 2 deleted observations.

@peiyaoli2
Copy link
Author

@evanmiller can you take a look at this? Thanks!

@evanmiller
Copy link
Contributor

Hi, I would need a sample file to address this issue.

@evanmiller
Copy link
Contributor

It looks like this code may help

troels/pandas@b31144a

@peiyaoli2
Copy link
Author

Hi! Here is the datetime.sas7bdat used to repro this:
datetime.sas7bdat.zip

It's the same file as the pandas-dev/pandas#15963 issue

@evanmiller
Copy link
Contributor

@peiyaoli2 Thanks for the link to the file. Based on the code that I linked, it looks like skipping deleted rows will be a bit of work. I'll leave this issue open, but I'm going to change it from a "bug" to an "enhancement".

@evanmiller evanmiller changed the title Deleted observations in SAS are being read Skip deleted observations in SAS7BDAT files Jan 16, 2023
@peiyaoli2
Copy link
Author

@evanmiller Hi! I would like to know if there is any ETA on when this feature can be supported. Thanks!

@ito4natsf
Copy link

@evanmiller Hi. My client is facing this issue and needs an immediate fix. So I'd also like to know if there is any ETA for this to be implemented. Thanks and regards.

@ito4natsf
Copy link

@evanmiller Hi, sorry for bothering you as I send you again, but could you provide ETA for this to be implemented?

@evanmiller
Copy link
Contributor

No ETA

@ito4natsf
Copy link

@evanmiller Could you please implement this enhancement, since my customer using readstat repeatedly asks me to do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants