Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

i18n: Merge similar translation strings #35

Merged
merged 2 commits into from
Mar 27, 2020

Conversation

mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Mar 26, 2020

image

@jeffpaul jeffpaul added this to the 0.4.0 milestone Mar 26, 2020
@@ -731,15 +731,15 @@ function wp_autoupdates_debug_information( $info ) {
/* translators: %s: Latest plugin version number. */
$plugin_version_string .= ' ' . sprintf( __( '(Latest version: %s)', 'wp-autoupdates' ), $plugin_updates[ $plugin_path ]->update->new_version );
/* translators: %s: Latest plugin version number. */
$plugin_version_string_debug .= ' ' . sprintf( __( '(latest version: %s)', 'wp-autoupdates' ), $plugin_updates[ $plugin_path ]->update->new_version );
$plugin_version_string_debug .= ' ' . sprintf( __( '(Latest version: %s)', 'wp-autoupdates' ), $plugin_updates[ $plugin_path ]->update->new_version );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not completely collapse this into $plugin_version_string?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jeffpaul,

$plugin_version_string and $plugin_version_string_debug both variable used for diffrent pepose.

$plugin_version_string in value and $plugin_version_string_debug use for debug

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.
However @mukeshpanchal27 I think it would be better to use the lowercase version 😃
Can you please update the patch accordingly?

Thank you!

@@ -731,15 +731,15 @@ function wp_autoupdates_debug_information( $info ) {
/* translators: %s: Latest plugin version number. */
$plugin_version_string .= ' ' . sprintf( __( '(Latest version: %s)', 'wp-autoupdates' ), $plugin_updates[ $plugin_path ]->update->new_version );
/* translators: %s: Latest plugin version number. */
$plugin_version_string_debug .= ' ' . sprintf( __( '(latest version: %s)', 'wp-autoupdates' ), $plugin_updates[ $plugin_path ]->update->new_version );
$plugin_version_string_debug .= ' ' . sprintf( __( '(Latest version: %s)', 'wp-autoupdates' ), $plugin_updates[ $plugin_path ]->update->new_version );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.
However @mukeshpanchal27 I think it would be better to use the lowercase version 😃
Can you please update the patch accordingly?

Thank you!

@audrasjb audrasjb added the i18n Internationalization label Mar 27, 2020
@audrasjb audrasjb merged commit 0d9b89d into WordPress:master Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i18n Internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants