Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-colon in SDL name is breaking the Linux build #21

Open
suetanvil opened this issue Jul 12, 2022 · 0 comments
Open

Double-colon in SDL name is breaking the Linux build #21

suetanvil opened this issue Jul 12, 2022 · 0 comments

Comments

@suetanvil
Copy link

When compiling on Ubuntu 20.04 using the system version of SDL2, the build fails in two places:

  1. cmake reports it can't find libSDL2. This is fixed by removing the 2.0.0 version arguments to find_package in CMakeLists.txt. (SDL is pretty good about backward compatibility so I'm reasonably confident this won't be a source of problems.)

  2. Linking fails with a message that it can't find SDL::SDL. This is fixed by removing the SDL:: prefix from the SDL packages. It also fixes a bunch of cmake warnings.

Once these changes are made, the build succeeds.

I've attached my changes as a diff but I can submit a pull request if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant