Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement animated particles that aren't tied to the global animation timer #2354

Merged
merged 4 commits into from Jan 9, 2024

Conversation

RicardoLuis0
Copy link
Collaborator

Allows both particles and visual thinkers to use ANIMDEFS independently from the global animation timer with SPF_STANDALONE_ANIMATIONS

@MajorCooke
Copy link
Contributor

I'd like to recommend another name for the flag: SPF_TICRATE.

@RicardoLuis0
Copy link
Collaborator Author

I'd like to recommend another name for the flag: SPF_TICRATE.

that name seems much more ambiguous

@madame-rachelle
Copy link
Collaborator

I'd like to recommend another name for the flag: SPF_TICRATE.

that name seems much more ambiguous

Agreed - I think the original name is better. It may be long but at least you know what it's doing.

@MajorCooke
Copy link
Contributor

MajorCooke commented Jan 8, 2024

How's it ambiguous when it does exactly what the name says on the tin? It converts the system to using tics instead of ms time. For me, "standalone animation" doesn't tell me anything. "ticrate" on the other hand sticks out to me much more.

@RicardoLuis0
Copy link
Collaborator Author

the difference the flag makes is the switch between "global" and "local" animations, that the local animation uses the level tic count is just a detail

@MajorCooke
Copy link
Contributor

How about SPF_LOCAL_ANIM then?

@MajorCooke
Copy link
Contributor

Thank you!

@madame-rachelle madame-rachelle merged commit b7e5d3d into ZDoom:master Jan 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants