Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required files for default services #19

Closed
wants to merge 1 commit into from

Conversation

mmomtchev
Copy link
Contributor

Fix #18

@mmomtchev
Copy link
Contributor Author

@gfenoy or maybe, as an alternative, use the one provided with the default binary image in /var/www/html/data?

@gfenoy
Copy link
Contributor

gfenoy commented Apr 11, 2022

@gfenoy or maybe, as an alternative, use the one provided with the default binary image in /var/www/html/data?

Indeed, the examples repository already contains the required files. But, as we are now using a volume for /usr/com/zoo-project the file are only available in /var/www/html/data even if they are copied in the right location in the Dockerfile on line 336.

I am wondering if it would be better to use symbolic links from /usr/com/zoo-project to /var/www/html/data for both topofr.tif and station1.gml. This way we don't need to download twice the same files.

@mmomtchev
Copy link
Contributor Author

git + symlinks + Windows is a horrible mix
I don't know how is the binary image generated? Or maybe simply configure the GDAL service to use /var/www/html/data

@mmomtchev
Copy link
Contributor Author

@gfenoy I think that the best solution is to make Docker prepoluate this directory:
https://docs.docker.com/storage/volumes/#populate-a-volume-using-a-container

Where does this file come from? It is not in the git repository, yet it is in the official image?

@gfenoy
Copy link
Contributor

gfenoy commented Apr 12, 2022

git + symlinks + Windows is a horrible mix

Agreed.

I don't know how is the binary image generated? Or maybe simply configure the GDAL service to use /var/www/html/data

The binary image is generated using a dedicated GitHub Action.

@gfenoy
Copy link
Contributor

gfenoy commented Apr 12, 2022

@gfenoy I think that the best solution is to make Docker prepoluate this directory: https://docs.docker.com/storage/volumes/#populate-a-volume-using-a-container

Where does this file come from? It is not in the git repository, yet it is in the official image?

The files required by the examples are stored in another dedicated GitHub repository: https://github.com/ZOO-Project/examples

This repo is cloned from the Dockerfile used by the GitHub Action: https://github.com/ZOO-Project/ZOO-Project/blob/main/.github/workflows/docker-image.yml responsible for building and pushing the official image

Populating the directory looks perfect to me

@mmomtchev
Copy link
Contributor Author

Superseded by #25

@mmomtchev mmomtchev closed this Apr 18, 2022
@mmomtchev mmomtchev deleted the topofr branch April 18, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/usr/com/zoo-project/ does not contain topofr.tif after a default install
2 participants