Add MemoryIndexAnalysis, for #22

Author: Zomis

src/main/groovy/net/zomis/brainf/analyze/Brainalyze.groovy

@@ -16,7 +16,6 @@ class Brainalyze implements BrainfuckListener {
     private final MemoryCell[] cells
     private final GroovyBFContext groovy
     @PackageScope final Map<Class<?>, Object> analysis = [:]
-    private boolean memoryIndexBelowZero
     private int maxMemory
 
     public <T extends BrainfuckAnalyzer> T get(Class<T> clazz) {
@@ -58,10 +57,6 @@ class Brainalyze implements BrainfuckListener {
 
         println 'Brainfuck Analyze'
         println '-----------------'
-        if (this.memoryIndexBelowZero) {
-            println 'WARNING: Memory index goes below zero'
-        }
-        println()
         println 'Tape summary'
         for (int i = 0; i <= maxMemory; i++) {
             MemoryCell cell = cells[i]
@@ -80,10 +75,6 @@ class Brainalyze implements BrainfuckListener {
         BrainFCommand command = (BrainFCommand) cmd
         MemoryCell cell = cells[runner.memory.memoryIndex]
 
-        if (command == BrainFCommand.PREVIOUS && runner.memory.memoryIndex == 0) {
-            this.memoryIndexBelowZero = true
-        }
-
         switch (command) {
             case BrainFCommand.ADD:
             case BrainFCommand.SUBTRACT:
@@ -129,8 +120,4 @@ class Brainalyze implements BrainfuckListener {
         result
     }
 
-    boolean isMemoryIndexBelowZero() {
-        this.memoryIndexBelowZero
-    }
-
 }

src/main/groovy/net/zomis/brainf/analyze/analyzers/MemoryIndexAnalysis.groovy

@@ -0,0 +1,59 @@
+package net.zomis.brainf.analyze.analyzers
+
+import net.zomis.brainf.analyze.BrainfuckAnalyzer
+import net.zomis.brainf.analyze.MemoryCell
+import net.zomis.brainf.model.BrainfuckCommand
+import net.zomis.brainf.model.BrainfuckRunner
+import net.zomis.brainf.model.classic.BrainFCommand
+
+class MemoryIndexAnalysis implements BrainfuckAnalyzer {
+
+    private boolean memoryIndexBelowZero
+    private boolean memoryIndexAboveMax
+    private int rightmostMemory
+
+    @Override
+    void print() {
+        if (this.memoryIndexBelowZero) {
+            println 'WARNING: Memory index goes below zero'
+        }
+        if (this.memoryIndexAboveMax) {
+            println 'WARNING: Memory index goes above maximum'
+        }
+        if (this.rightmostMemory > 30_000) {
+            println 'WARNING: Memory index goes above 30 000'
+        } else if (this.rightmostMemory > 9_999) {
+            println 'WARNING: Memory index goes above 9 999'
+        }
+        println "Rightmost memory accessed is $rightmostMemory"
+        println()
+    }
+
+    @Override
+    void beforePerform(MemoryCell cell, BrainfuckRunner runner, BrainfuckCommand command) {
+        if (command == BrainFCommand.PREVIOUS && runner.memory.memoryIndex == 0) {
+            this.memoryIndexBelowZero = true
+        }
+        if (command == BrainFCommand.NEXT && runner.memory.memoryIndex == runner.memory.size - 1) {
+            this.memoryIndexAboveMax = true
+        }
+    }
+
+    @Override
+    void afterPerform(MemoryCell cell, BrainfuckRunner runner, BrainfuckCommand command) {
+        this.@rightmostMemory = Math.max(this.@rightmostMemory, runner.memory.memoryIndex)
+    }
+
+    boolean isMemoryIndexBelowZero() {
+        this.@memoryIndexBelowZero
+    }
+
+    boolean isMemoryIndexAboveMax() {
+        this.@memoryIndexAboveMax
+    }
+
+    int getRightmostMemory() {
+        this.@rightmostMemory
+    }
+
+}

src/test/groovy/net/zomis/brainf/BrainfuckTest.groovy

@@ -6,6 +6,7 @@ import net.zomis.brainf.analyze.BrainfuckAnalyzer
 import net.zomis.brainf.analyze.analyzers.CommandCountAnalysis
 import net.zomis.brainf.analyze.analyzers.GroovyCommandAnalysis
 import net.zomis.brainf.analyze.analyzers.IOAnalysis
+import net.zomis.brainf.analyze.analyzers.MemoryIndexAnalysis
 import net.zomis.brainf.analyze.analyzers.MemoryValues
 import net.zomis.brainf.analyze.analyzers.ReadWriteAnalysis
 import net.zomis.brainf.analyze.analyzers.WhileLoopAnalysis
@@ -50,6 +51,7 @@ class BrainfuckTest {
               new ReadWriteAnalysis(),
               new WhileLoopAnalysis(),
               new CommandCountAnalysis(),
+              new MemoryIndexAnalysis(),
         ]
         analyze(analyzers)
     }

src/test/groovy/net/zomis/brainf/ValidateTest.groovy

@@ -1,5 +1,6 @@
 package net.zomis.brainf
 
+import net.zomis.brainf.analyze.analyzers.MemoryIndexAnalysis
 import net.zomis.brainf.analyze.analyzers.MemoryValues
 import org.junit.Test
 
@@ -8,15 +9,17 @@ class ValidateTest extends BrainfuckTest {
     @Test
     void moveNegativeIndex() {
         source.addCommands('+<<++')
-        analyze()
-        assert analyze.isMemoryIndexBelowZero()
+        analyze(new MemoryIndexAnalysis())
+        assert analyze.get(MemoryIndexAnalysis).isMemoryIndexBelowZero()
+        assert !analyze.get(MemoryIndexAnalysis).isMemoryIndexAboveMax()
     }
 
     @Test
     void stayPositiveIndex() {
         source.addCommands('+>+<++')
-        analyze()
-        assert !analyze.isMemoryIndexBelowZero()
+        analyze(new MemoryIndexAnalysis())
+        assert !analyze.get(MemoryIndexAnalysis).isMemoryIndexBelowZero()
+        assert !analyze.get(MemoryIndexAnalysis).isMemoryIndexAboveMax()
     }
 
     @Test