Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SkipList. Fixed Issues #137, #138, #139, #140 #147

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update SkipList. Fixed Issues #137, #138, #139, #140 #147

wants to merge 5 commits into from

Conversation

Gutsonok
Copy link
Contributor

@Gutsonok Gutsonok commented Aug 5, 2020 •
edited

Description

Fixed #137 . This bug occurs when _getNextLevel() method returned 0.

Fixed #138 and #139 . This bug occurs because of skip list was сircular.

Fixed #140. This bug occurs comparing method was called for null object.

I add implementaion for public T this[T item]. I think this should be work like a standard Dictionary type.

I divided a unit test for SkipList on some tests. And added additinal tests.

Checklist

  • An issues were first created before opening this pull request
  • The new code follows the contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to ensure that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Gutsonok Gutsonok changed the title Fixed Issue #137 Items are not always added to a SkipList Update SkipList. Fixed Issues #137, #138, #139 Aug 8, 2020
@Gutsonok Gutsonok changed the title Update SkipList. Fixed Issues #137, #138, #139 Update SkipList. Fixed Issues #137, #138, #139, #140 Aug 8, 2020
@aalhour aalhour self-requested a review December 22, 2020 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalhour aalhour Awaiting requested review from aalhour

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Gutsonok