fix(#8): add standard ccov excluded directories by default

abdes · Aug 11, 2022 · a8aabb3 · a8aabb3
1 parent 0d9187e
commit a8aabb3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -190,8 +190,7 @@ if(ASAP_BUILD_TESTS)
   include(GoogleSanitizers)
   include(CodeCoverage)
   # Enable this target when the project has test cases
-  # asap_add_code_coverage_all_targets( EXCLUDE */test/* *googlemock*
-  # *googletest* /usr/*)
+  # asap_add_code_coverage_all_targets()
   include(Valgrind)
 
   cpmaddpackage(

diff --git a/cmake/CodeCoverage.cmake b/cmake/CodeCoverage.cmake
@@ -16,7 +16,17 @@ if("${CMAKE_C_COMPILER_ID}" MATCHES "(Apple)?[Cc]lang|GNU")
   endfunction()
 
   function(asap_add_code_coverage_all_targets)
-    add_code_coverage_all_targets(${ARGV})
+    # Add standard exclusion patterns for code coverage reports
+    if("${CMAKE_C_COMPILER_ID}" MATCHES "(Apple)?[Cc]lang")
+      # For clang we'll be using llvm-cov which expect regex as input for
+      # exclusions
+      set(STANDARD_EXCLUDES '.*/test/.*' '.*/\.cache/CPM/.*' '/usr/.*')
+    else()
+      # For GNU however, we'll be using lcov which expects file patterns as
+      # input for excludions
+      set(STANDARD_EXCLUDES */test/* */.cache/CPM/* /usr/*)
+    endif()
+    add_code_coverage_all_targets(EXCLUDE ${STANDARD_EXCLUDES} ${ARGV})
   endfunction()
 
 else()