Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take complete control of our Maven POM #76

Open
QuintinWillison opened this issue May 26, 2022 · 0 comments
Open

Take complete control of our Maven POM #76

QuintinWillison opened this issue May 26, 2022 · 0 comments
Labels
code-quality Affects the developer experience when working in our codebase.

Comments

@QuintinWillison
Copy link
Contributor

QuintinWillison commented May 26, 2022

Since the initial commit in this repository our POM has inherited from a parent POM.

I believe this was in order to bootstrap this project quickly, based on this quick start:
https://github.com/jcustenborder/kafka-connect-archtype

Described to me as producing:

a scaffolded project with default opinions

Looking at the sources involved, in the best case they've not been worked on in a year, and in the worst case it's more like five years (the checkstyle config 🙄, see also #74). On top of this, I'm pretty sure that none of these sources are being actively maintained or otherwise cared for (perhaps further evidenced by the lack of activity on jcustenborder/kafka-connect-archtype#13, being a pull request submitted to fix up the aforementioned 'quick start', but effectively ignored by its creator).

I would much rather get rid of external dependency specification and configuration injection like this and start controlling the full domain ourselves. This might be as simple as replacing our POM with the output of help:effective-pom and thinning / improving from there. But, I'll admit, I'm not a Maven expert.

These foundations are like walking around in concrete boots for developers working on this repository, especially those less familiar with Kafka - or even Maven. We need:

  • take back control of all project dependencies
  • start preferring Maven convention, over configuration
  • only deviate from Maven convention when that is required to make the solution work

┆Issue is synchronized with this Jira Uncategorised by Unito

@QuintinWillison QuintinWillison added the code-quality Affects the developer experience when working in our codebase. label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Affects the developer experience when working in our codebase.
Development

No branches or pull requests

1 participant