Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of extended subsets of 'Source Sans Pro' fonts #212

Open
stochmalm opened this issue Oct 16, 2018 · 2 comments
Open

Support of extended subsets of 'Source Sans Pro' fonts #212

stochmalm opened this issue Oct 16, 2018 · 2 comments

Comments

@stochmalm
Copy link

stochmalm commented Oct 16, 2018

Issue Overview

Hello again,
I'm using admin-theme in a project with polish language and there're problems with non-standard polish characters encoding (ą, ę, ć, ó, ł, ź, ż). To solve this I'm importing ext-latin subset via cdn:

@import url('https://fonts.googleapis.com/css?family=Source+Sans+Pro:400,600,900&subset=latin-ext');

I think there should be a maven classifier for selecting 'Source Sans Pro' font subset of your own choice.
These subsets are supported for this font on google fonts:

  • Cyrillic (Supported by Source Sans Pro)
  • Cyrillic Extended (Supported by Source Sans Pro)
  • Greek (Supported by Source Sans Pro)
  • Greek Extended (Supported by Source Sans Pro)
  • Latin (Supported by all Fonts)
  • Latin Extended (Supported by Source Sans Pro)
  • Vietnamese (Supported by Source Sans Pro)
Current Behaviour

image

Expected Behaviour

image

Additional Information
  • AdminFaces version: 1.0.0-RC19
  • PrimeFaces version: 6.2
  • Browser version: All

I'll try to contribute in my spare time.

@rmpestano
Copy link
Contributor

Hi,

Maybe we should have a classifier which would import no fonts at all and then users could import the fonts on their template page. Of course the user provided font must be a sub set of source sans pro as it is being declared on the theme css.

As we already have a 'no-fonts' classifier (bad name by the way) we need to introduce a new classifier, it can be named 'user-font', WDYT?

Thank you for this feedback

@stochmalm
Copy link
Author

Sorry, I didn't have any time recently to answer. Well I think this way or another will be OK. Possibility of removing font imports from theme.css will be sufficient enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants