-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugs with Image component referencing Page featured image #2741
Comments
For the bug: "On the Image policy dialog, a JS error causes "Get alternative text from DAM" selection to be hidden until a different checkbox is clicked" The fix for this one is simple. #2249 was the commit that added the Image editor JS lib to the design dialog (which causes the error), but #2288 fully reverted the JS changes that triggered the need to add the lib to the design dialog in the first place. As such, I believe we can simply remove |
For the bug: "When you add a Link to an image component when inheriting featured image from the page, a JS error prevents from saving "Alternative text for acessibility" even if a value is in the field" The issue is in apps/core/wcm/components/image/v3/image/clientlibs/editor/js/image.js. What's happening is the logic that is added to display a nice error message for missing alt text ("Error: Please provide an asset which has a description that can be used as alt text.") is checking the wrong checkbox when using a page image. When using a page image, if the (hidden) checkbox for "altValueFromDAM" is checked, the validation think you're still trying to default from DAM value and throws an error for that value being empty, regardless of you having entered your own alt text. The following code:
Needs to be updated to have |
For the bug: "When image component references a page image, "alternative text for accessibility" on dialog loads as empty unless you uncheck/check the "alternative text for accessibilty" box" The issue is in apps/core/wcm/components/image/v3/image/clientlibs/editor/js/image.js. After the dialog loads and the thumbnail is updated to show the referenced page image, there is logic that hides the checkbox for "get alt text from DAM" ( To remedy this, the following code snippet should be updated to re-update the
|
For the bug: "When image component references a page image, "alternative text for accessibility" can be saved as empty" There's a couple issues, which I think stem from https://github.com/adobe/aem-core-wcm-components/pull/1995/files which added a check to verify the fileupload field is visible. The "required" value for the alt field is incorrect in two scenarios:
To fix the issue on initial dialog load, we can add a call in
To fix the issue on toggle of the "image from page" checkbox, update
There may be more ideal/elegant fixes, but this seems to work for me. |
Bugs current as of: 2.24.7-SNAPSHOT
The text was updated successfully, but these errors were encountered: