Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transparently use site auth in sidekick #559

Open
davidnuescheler opened this issue Oct 11, 2023 · 3 comments
Open

transparently use site auth in sidekick #559

davidnuescheler opened this issue Oct 11, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@davidnuescheler
Copy link

i think that in many cases .page and .live could use the same token as the admin service, so it would be great if we could just use that site auth for sidekick.

maybe i am (as usual) oversimplifying things here :)

@davidnuescheler davidnuescheler added the enhancement New feature or request label Oct 11, 2023
@rofe
Copy link
Contributor

rofe commented Oct 11, 2023

@tripodsan thoughts?

@tripodsan
Copy link
Contributor

tripodsan commented Oct 13, 2023

the main problem is how to transfer the token from the site auth to the sidekick?
we might be able to set it on *.hlx.page because it's a public domain:
https://publicsuffix.org/list/public_suffix_list.dat
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#domaindomain-value

then we would use the same token for all helix projects... which might be ok.

another sideeffect will be that we can't access the profile image anymore, since the token cannot be used to talk to the original IDP.

@davidnuescheler
Copy link
Author

another sideeffect will be that we can't access the profile image anymore, since the token cannot be used to talk to the original IDP.

looking at the logs i am not sure that we can fetch that image reliably anyway... any thoughts on using gravatar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants