Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace replace_executor with use of require #445

Open
jaredhoberock opened this issue Apr 2, 2018 · 0 comments
Open

Replace replace_executor with use of require #445

jaredhoberock opened this issue Apr 2, 2018 · 0 comments

Comments

@jaredhoberock
Copy link
Collaborator

Now that we have require, the additional customization point replace_executor may be unnecessary.

.on() could instead work like this:

template<class OtherExecutor>
auto on(const OtherExecutor& ex) const
{
  // require the current executor's bulk guarantee
  auto replacement = require(ex, bulk, query(this->executor(), bulk_guarantee))
  return {replacement};
}

We should be able to eliminate replace_executor and its customizations this way.

@jaredhoberock jaredhoberock added this to the Release0.3 milestone Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant